Added check to model to ensure we take off the distributed wrapper #487
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
farisalasmary
suggested changes
Mar 2, 2020
utils.py
Outdated
| :param model: The training model | ||
| :return: The model without parallel wrapper | ||
| """ | ||
| return model.module if isinstance(model, torch.nn.parallel.DistributedDataParallel) else model |
Contributor
There was a problem hiding this comment.
torch.nn.parallel.DistributedDataParallel MUST be replaced with apex.parallel.DistributedDataParallel and this is what happened when I executed the following print statements inside train.py:
print('isinstance(model, torch.nn.parallel.DistributedDataParallel): ', isinstance(model, torch.nn.parallel.DistributedDataParallel))
print('isinstance(model, apex.parallel.DistributedDataParallel): ', isinstance(model, apex.parallel.DistributedDataParallel))The output that I got is:
isinstance(model, torch.nn.parallel.DistributedDataParallel): False
isinstance(model, apex.parallel.DistributedDataParallel): True
Owner
Author
|
I've seen a much cleaner solution to this, checking if the model has a module attribute. I'll implement this instead! |
Owner
Author
|
Added the commit, will test it and merge, @farisalasmary if you're able to test as well that would be good! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #475