Skip to content

Fix download retries not happening on error during download #203

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 12, 2025
Merged

Fix download retries not happening on error during download #203

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
08c6678
fix request not properly being destroyed
Sebastian-Webster Feb 12, 2025
ee76fbb
Merge branch 'main' into 198-download-request-does-not-retry-on-failu…
Sebastian-Webster Feb 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
40 changes: 22 additions & 18 deletions src/libraries/Downloader.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,31 +65,35 @@ function downloadFromCDN(url: string, downloadLocation: string, logger: Logger):
request.on('error', (err) => {
error = err;
logger.error(err)
request.end(() => {
fileStream.end(() => {
fs.rm(downloadLocation, {force: true}, (rmError) => {
if (rmError) {
logger.error('An error occurred while deleting downloadLocation after an error occurred with the MySQL server binary download. The error was:', rmError)
}

reject(err.message);
})
request.destroy();

fileStream.end((err) => {
if (err) {
logger.error('An error occurred while closing the fileStream on request error. The error was:', err)
}

fs.rm(downloadLocation, {force: true}, (rmError) => {
if (rmError) {
logger.error('An error occurred while deleting downloadLocation after an error occurred with the MySQL server binary download. The error was:', rmError)
}

reject(err.message);
})
})
})

fileStream.on('error', (err) => {
error = err;
logger.error(err)
request.end(() => {
fileStream.end(() => {
fs.rm(downloadLocation, {force: true}, (rmError) => {
if (rmError) {
logger.error('An error occurred while deleting downloadLocation after an error occurred with the fileStream. The error was:', rmError)
}

reject(err.message)
})
request.destroy();

fileStream.end(() => {
fs.rm(downloadLocation, {force: true}, (rmError) => {
if (rmError) {
logger.error('An error occurred while deleting downloadLocation after an error occurred with the fileStream. The error was:', rmError)
}

reject(err.message)
})
})
})
Expand Down
Loading