Skip to content

Conversation

@Sebastian-Webster
Copy link
Owner

This pull request closes #256

Before the most recent commit from the triggering branch was checked out. This is fine when there are only workflows triggered by the most recent commit. In cases where commits are made to a pull request in quick succession, the workflows in the queue may checkout the newer code by the time the workflow starts running. That leads to the workflow checking out the incorrect code, making it harder to track down behaviour changes when code is changing fast.

Now the workflow checks out all the history from the triggering branch, and then checks out the commit from the triggering commit SHA.

@Sebastian-Webster Sebastian-Webster self-assigned this Oct 22, 2025
@Sebastian-Webster Sebastian-Webster added bug Something isn't working tests Modifies/adds/removes tests labels Oct 22, 2025
@Sebastian-Webster Sebastian-Webster linked an issue Oct 22, 2025 that may be closed by this pull request
@Sebastian-Webster Sebastian-Webster added the Linux The issue specifically relates to mysql-memory-server running on Linux platforms label Oct 22, 2025
@Sebastian-Webster Sebastian-Webster merged commit 57d529d into main Oct 24, 2025
363 checks passed
@Sebastian-Webster Sebastian-Webster deleted the 256-alpine-tests-do-not-checkout-correct-commit branch October 24, 2025 03:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working Linux The issue specifically relates to mysql-memory-server running on Linux platforms tests Modifies/adds/removes tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Alpine tests do not checkout correct commit

2 participants