Update RoleManagementApiTest to use sanctum guard

[kevalyq]

🎯 Objective

Update tests/Feature/RoleManagementApiTest.php to create permissions with guard_name='sanctum' instead of defaulting to 'web' guard.

📋 Changes Required

Location

File: tests/Feature/RoleManagementApiTest.php
Lines: ~50-56 (beforeEach hook)

Current Code

beforeEach(function (): void {
    $this->tenant = Tenant::factory()->create();
    $this->user = User::factory()->create(['tenant_id' => $this->tenant->id]);
    $this->token = $this->user->createToken('test')->plainTextToken;

    // Create test permissions (implicit 'web' guard)
    Permission::create(['name' => 'roles.read']);
    Permission::create(['name' => 'roles.create']);
    Permission::create(['name' => 'roles.update']);
    Permission::create(['name' => 'roles.delete']);
    // ... more permissions
});

Target Code

beforeEach(function (): void {
    $this->tenant = Tenant::factory()->create();
    $this->user = User::factory()->create(['tenant_id' => $this->tenant->id]);
    $this->token = $this->user->createToken('test')->plainTextToken;

    // Create test permissions (explicit 'sanctum' guard)
    Permission::create(['name' => 'roles.read', 'guard_name' => 'sanctum']);
    Permission::create(['name' => 'roles.create', 'guard_name' => 'sanctum']);
    Permission::create(['name' => 'roles.update', 'guard_name' => 'sanctum']);
    Permission::create(['name' => 'roles.delete', 'guard_name' => 'sanctum']);
    // ... more permissions
});

✅ Acceptance Criteria

• All Permission::create() calls include 'guard_name' => 'sanctum'
• Tests pass locally after change
• PHPStan Level Max: 0 errors
• Laravel Pint: Clean
• No other test files affected

📊 Expected Impact

Before: 3 tests failing with PermissionDoesNotExist errors
After: All 26 tests pass

🔗 Related

• Parent: [EPIC] Migrate Permission System from 'web' to 'sanctum' Guard #125 (EPIC: Migrate Permission System to sanctum guard)
• Depends on: None (can be done independently)

⏱️ Effort Estimate

Time: 20-30 minutes
Complexity: Low (mechanical change, well-defined scope)

[github-actions]

✅ This issue has been added to the SecPal Feature Roadmap with status: 💡 Ideas

New idea - needs discussion and evaluation

Status Flow:
💡 Ideas → 💬 Discussion → 📥 Backlog → 📋 Planned → 🚧 In Progress → 👀 In Review → ✅ Done

Note: Ideas that won't be implemented should be moved to 🚫 Won't Do with a reason.