Fix SecretAttachment Model tests (encryption pattern violations)

[kevalyq]

Problem

5 Model unit tests in tests/Feature/Models/SecretAttachmentTest.php failing due to improper encryption pattern in test setup.

Root Cause

Secret::create() and SecretAttachment::create() do NOT follow explicit property assignment pattern required for EncryptedWithDek cast.

Required: $model = new Model(); $model->tenant_id = $tenantId; $model->encrypted_field = $value; $model->save();

Current (broken): Model::create(['tenant_id' => ..., 'encrypted_field' => ...]);

Failing Tests

1. secret attachment uses UUID primary key
2. secret attachment encrypts filename with EncryptedWithDek cast
3. secret attachment belongs to secret
4. secret attachment belongs to user (uploaded_by)
5. secret attachment has download_url accessor

Solution

Replace all ::create() calls with explicit property assignment pattern.

Impact

• Tests failing but functionality works (Controller tests 13/13 passing)
• Blocks: Nothing (PR feat: File Attachments API (Phase 2) #175 #177 can proceed)

Related

• PR feat: File Attachments API (Phase 2) #175 #177
• Phase 2: File Attachments API (Upload/Download/Encryption) #175

[github-actions]

✅ This issue has been added to the SecPal Feature Roadmap with status: 💡 Ideas

New idea - needs discussion and evaluation

Status Flow:
💡 Ideas → 💬 Discussion → 📥 Backlog → 📋 Planned → 🚧 In Progress → 👀 In Review → ✅ Done

Note: Ideas that won't be implemented should be moved to 🚫 Won't Do with a reason.