Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 10 additions & 9 deletions .github/copilot-instructions.md
Original file line number Diff line number Diff line change
Expand Up @@ -249,10 +249,11 @@ protected function isAccessible(User $user, ?string $path = null): bool
- Tests live in the `tests/Feature` and `tests/Unit` directories.
- Pest tests look and behave like this:
<code-snippet name="Basic Pest Test Example" lang="php">
it('is true', function () {
expect(true)->toBeTrue();
});
</code-snippet>

it('is true', function () {
expect(true)->toBeTrue();
});
</code-snippet>

### Running Tests

Expand All @@ -266,13 +267,13 @@ protected function isAccessible(User $user, ?string $path = null): bool

- When asserting status codes on a response, use the specific method like `assertForbidden` and `assertNotFound` instead of using `assertStatus(403)` or similar, e.g.:
<code-snippet name="Pest Example Asserting postJson Response" lang="php">
it('returns all', function () {
$response = $this->postJson('/api/docs', []);

$response->assertSuccessful();
it('returns all', function () {
$response = $this->postJson('/api/docs', []);

});
</code-snippet>
$response->assertSuccessful();
});
</code-snippet>

### Mocking

Expand Down
5 changes: 5 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -63,6 +63,11 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

### Fixed

- **Markdown Linting** - Fixed 88 markdown-lint errors in `.github/copilot-instructions.md` (#123)
- Added blank lines around headings (MD022)
- Added blank lines around lists (MD032)
- Removed multiple consecutive blank lines (MD012)
- Fixed unordered list indentation to 2 spaces (MD007)
- **Permission System Guard Migration** - Migrated from 'web' to 'sanctum' guard (#126, #127, #128, #129)
- Fixed `RoleApiTest.php` - Added explicit `guard_name='sanctum'` to all Permission and Role creation
- Fixed `PersonApiTest.php` - Changed `guard_name` from 'web' to 'sanctum' for person permissions
Expand Down