feat: org .github DRY & preflight (PR-0) #51
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add .github/workflows/php-ci.yml referencing org reusable workflows - Document KEK generation and envelope encryption setup in README - Add preflight checklist for development - Create PEST smoke tests for env/config validation - Document coverage driver setup (pcov/xdebug) Relates to #50
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds infrastructure for smoke testing environment configuration, updates documentation with KEK setup instructions, and establishes CI workflow with coverage requirements.
- Adds environment configuration smoke tests to verify essential config values and database connectivity
- Documents KEK (Key Encryption Key) generation and setup for envelope encryption
- Implements CI workflow with Laravel Pint, PHPStan, and PEST tests requiring ≥80% coverage
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| tests/Feature/EnvConfigSmokeTest.php | Adds Pest smoke tests for verifying environment configuration and database connection |
| README.md | Documents KEK setup for envelope encryption, adds coverage requirements, and includes preflight checklist |
| .github/workflows/php-ci.yml | Defines CI workflow with linting, static analysis, and testing jobs with 80% coverage requirement |
- Convert test to pure Pest style (remove describe wrapper) - Use config() helper instead of Config facade - Add mkdir -p for KEK directory creation - Add sudo for pcov installation documentation Addresses Copilot review feedback on PR #51
app.key is null in CI without .env, causing test failure. Use app.debug which has a default value in config/app.php. Fixes CI test failure in PEST Tests workflow
Coverage will be enforced in subsequent PRs when actual application code is added. PR-0 only sets up infrastructure.
- Replace generic Exception with Laravel's QueryException - Use DB::select() instead of getPdo() for cleaner test - Follows Laravel Boost best practices Addresses Copilot review comment #2483790612
- Use dynamic PHP version detection for pcov.ini path - Change KEK_PATH to relative path for development - Add production guidance as blockquote Addresses Copilot comments #2483794577 and #2483794578
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR establishes the foundation for DRY CI/CD and development workflows by:
.github/workflows/php-ci.ymlthat references org-wide reusable workflows for PHP linting (Pint), static analysis (Larastan/PHPStan), and testing (PEST with ≥80% coverage).EnvConfigSmokeTest) to validate environment configuration and database connectivity.Changes
.github/workflows/php-ci.yml→ References org reusable workflowsREADME.md→ KEK generation, preflight checklist, coverage setuptests/Feature/EnvConfigSmokeTest.php→ Env/config smoke testsQuality Gates
Testing
Relates to
Fixes #50 (PR-0: Org
.githubDRY & Preflight)Next PR: PR-1 (Migrations & Base Schema)