refactor: Address Copilot review nitpicks #54
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ants - Clarify idx_key inline comment (HMAC-SHA256 blind indexes) - Replace magic number 32 with SODIUM_CRYPTO_SECRETBOX_KEYBYTES in tests - Define HMAC_SHA256_OUTPUT_BYTES constant for SHA-256 output length - Consistent use of libsodium constants throughout tests
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR refactors hardcoded numeric literals in test assertions to use named constants, improving code maintainability and clarifying the intent behind cryptographic key size validations.
Key Changes:
- Introduced
HMAC_SHA256_OUTPUT_BYTESconstant (32 bytes) for blind index size assertions - Updated test assertions to use
SODIUM_CRYPTO_SECRETBOX_KEYBYTESconstant instead of hardcoded32 - Improved code comment clarity in the
TenantKeymodel
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| tests/Feature/TenantKeyTest.php | Adds HMAC_SHA256_OUTPUT_BYTES constant and replaces hardcoded 32 with appropriate named constants in test assertions |
| app/Models/TenantKey.php | Updates comment to clarify that the index key is 32 bytes and used for HMAC-SHA256 operations |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to PR #53 addressing the 4 remaining Copilot review comments that were resolved without being fixed.
Changes
unwraps idx_key correctly: UseSODIUM_CRYPTO_SECRETBOX_KEYBYTESconstantgenerates envelope keys: UseSODIUM_CRYPTO_SECRETBOX_KEYBYTESfor idx_wrapped checkgenerates consistent blind index: DefineHMAC_SHA256_OUTPUT_BYTESconstant for SHA-256 output lengthQuality
This addresses the nitpick comments from the Copilot review that were marked as resolved but not actually implemented.