fix: auto-detect DDEV for preflight checks

[kevalyq]

Problem

Pre-push hooks were failing when running tests outside DDEV environment because the PostgreSQL database container (db) was not accessible from the host. This caused 34 test failures during git push even when all tests passed via ddev exec.

Error Example:

SQLSTATE[08006] [7] could not translate host name "db" to address

Solution

Enhanced scripts/preflight.sh to auto-detect DDEV and run PHP checks (Pint, PHPStan, tests) inside the container when available.

Changes

• ✅ Add DDEV detection: command -v ddev && ddev describe
• ✅ Run Pint via ddev exec when DDEV is available
• ✅ Run PHPStan via ddev exec when DDEV is available
• ✅ Run tests via ddev exec when DDEV is available
• ✅ Fallback to host execution with warning when DDEV not detected
• ✅ User-friendly output: "✓ DDEV detected - using containerized environment"

Benefits

• 🎯 Fixes pre-push hook failures - Database-dependent tests now work during git push
• 🔒 Consistent environment - Same PHP/PostgreSQL versions in hooks as in development
• ⚡ No breaking changes - Falls back to host execution for non-DDEV setups
• 📝 Clear messaging - Users see when DDEV is used vs. host fallback

Testing

# Run preflight manually
./scripts/preflight.sh

# Test pre-push hook
git push origin fix/pre-commit-ddev-tests

# Output:
✓ DDEV detected - using containerized environment for PHP checks
Tests:    39 passed (89 assertions)
Preflight OK · Changed lines: 65

Related

• Resolves pre-commit outside DDEV issue mentioned in PR feat: PR-3 - Tenant Middleware & RBAC Wiring #55
• Complements existing DDEV-based development workflow

LOC

• Lines changed: 65
• Impact: scripts/preflight.sh (pre-push hook logic)

[Copilot]

Pull Request Overview

This PR enhances the preflight script to support DDEV containerized environments for PHP checks. The script now automatically detects DDEV and routes PHP-related commands (composer, Pint, PHPStan, and tests) through the DDEV container when available, ensuring consistent execution environments.

Key Changes:

• Added automatic DDEV detection with fallback to host execution
• Wrapped all PHP tooling commands (Pint, PHPStan, tests) with ddev exec when DDEV is available
• Added user-facing messages to indicate which environment is being used

[kevalyq]

✅ Addressed Copilot review feedback in commit d38b050:

Comment 1 - composer install in DDEV path:

• Added comment explaining that composer install is intentionally skipped in DDEV path
• Rationale: vendor/ directory is bind-mounted from host to container, dependencies are already managed by DDEV setup (ddev composer install during project initialization)
• No need to run composer in pre-push hook when using DDEV

Comment 2 - Warning message noise:

• Moved warning to only display after test failure when DDEV not available
• Added helpful tip: "Tip: Use DDEV for tests requiring PostgreSQL: ddev exec ./vendor/bin/pest"
• Capture and properly propagate test exit codes using TEST_EXIT variable
• Cleaner output for users with properly configured host environments

All CI checks passing ✅

[Copilot]

Pull Request Overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 4 comments.

[Copilot]

Pull Request Overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 2 comments.