🛡️ Automate Pint --test & CHANGELOG Validation

[kevalyq]

🛡️ Feature: Automate Pint & CHANGELOG Validation

Context: Post-PR #74 learnings documented in SELF_REVIEW_CHECKLIST.md were NOT integrated into automated quality gates. This PR closes that gap.

🎯 Problem Solved

Critical Gap: preflight.sh only ran pint --dirty (auto-fix), not pint --test --dirty (CI parity check). This meant:

• Auto-fix could hide issues that CI's pint --test would catch
• Same false confidence issue from PR 🔐 Password Reset Feature (Production Test Phase 1) #74 could recur
• Scripts didn't enforce what documentation said

📝 Changes

1. scripts/preflight.sh - Pint Workflow (CRITICAL)

Before:

run_pint() {
  ${cmd_prefix} ./vendor/bin/pint --dirty  # Only auto-fix
}

After:

run_pint() {
  # Check-first workflow (see SELF_REVIEW_CHECKLIST.md)
  echo "→ Checking code style (pint --test --dirty)..."
  if ! ${cmd_prefix} ./vendor/bin/pint --test --dirty; then
    echo "→ Auto-fixing code style issues (pint --dirty)..."
    ${cmd_prefix} ./vendor/bin/pint --dirty
    echo "→ Verifying fix matches CI requirements (pint --test --dirty)..."
    ${cmd_prefix} ./vendor/bin/pint --test --dirty
  fi
}

Impact:

• ✅ Ensures CI parity (prevents false confidence)
• ✅ Matches documented workflow from SELF_REVIEW_CHECKLIST.md
• ✅ Auto-fixes when needed, then validates

2. .pre-commit-config.yaml - Add Pint Hook

- repo: local
  hooks:
    - id: pint
      name: Laravel Pint
      entry: vendor/bin/pint --dirty
      language: system
      types: [php]

Impact:

• ✅ Auto-fixes PHP files on commit
• ✅ Works with preflight.sh verification
• ✅ Fast (only changed files via --dirty)

3. scripts/preflight.sh - CHANGELOG Validation

# Checks for [Unreleased] section on feature/fix/refactor branches
# Exempts docs/* and chore/* branches
if [ -f CHANGELOG.md ] && [ "$CURRENT_BRANCH" != "main" ] && [[ ! "$CURRENT_BRANCH" =~ ^(docs|chore)/ ]]; then
  if ! grep -q "## \[Unreleased\]" CHANGELOG.md; then
    echo "❌ CHANGELOG.md missing [Unreleased] section"
    exit 1
  fi
fi

Impact:

• ✅ Enforces org-wide CHANGELOG policy automatically
• ✅ Prevents PR 🔐 Password Reset Feature (Production Test Phase 1) #74-style "forgot to update CHANGELOG" issues
• ✅ Smart exemptions for docs-only branches

🔒 Why This Matters

Before this PR:

• ✅ Best practices documented in SELF_REVIEW_CHECKLIST.md
• ❌ Not enforced by scripts → Relies on AI/human discipline
• ❌ Gap between documentation and automation

After this PR:

• ✅ Best practices documented
• ✅ Enforced by scripts automatically
• ✅ Documentation = Automation (aligned)

✅ Testing

Ran ./scripts/preflight.sh successfully:

• ✅ Pint check-fix-verify workflow executed correctly
• ✅ CHANGELOG validation working
• ✅ All 127 tests passing (376 assertions, 9.47s)
• ✅ Pre-commit hook tested locally

🔗 Related

• Trigger: PR 🔐 Password Reset Feature (Production Test Phase 1) #74 Pint false confidence issue
• Documentation: docs/SELF_REVIEW_CHECKLIST.md (PR 📚 Document Pint --test Critical Learning (Post-PR#74) #75)
• Instructions Reminder: PR 📋 Add Explicit Org-Wide Instructions Reminder #76
• Org Instructions: .github repo validation script

---

Review Focus: Verify Pint workflow matches SELF_REVIEW_CHECKLIST.md exactly. Check CHANGELOG validation logic for edge cases.

[github-actions]

💡 Tip: Consider Using Draft PRs

Benefits of opening PRs as drafts initially:

• 💰 Saves CI runtime and Copilot review credits
• 🎯 Automatically sets linked issues to "🚧 In Progress" status
• 🚀 Mark "Ready for review" when done to trigger full CI pipeline

How to convert:

1. Click "Still in progress? Convert to draft" in the sidebar, OR
2. Use gh pr ready when ready for review

This is just a friendly reminder - feel free to continue as is! 😊

[Copilot]

Pull Request Overview

This PR implements a check-first workflow for Laravel Pint and adds CHANGELOG validation to ensure CI parity and proper documentation maintenance. The changes align with established coding guidelines documented in SELF_REVIEW_CHECKLIST.md and .github/copilot-instructions.md.

Key Changes

• Updated Pint workflow in preflight.sh to check first (--test --dirty), auto-fix if needed, then verify
• Added Pint pre-commit hook to auto-fix changed files
• Implemented CHANGELOG validation to ensure [Unreleased] section has content on non-docs branches

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.

File	Description
scripts/preflight.sh	Refactored run_pint() to implement check-first workflow and added CHANGELOG validation checks
.pre-commit-config.yaml	Added Laravel Pint hook to auto-fix changed files during pre-commit

[github-actions]

💡 Tip: Consider Using Draft PRs

Benefits of opening PRs as drafts initially:

• 💰 Saves CI runtime and Copilot review credits
• 🎯 Automatically sets linked issues to "🚧 In Progress" status
• 🚀 Mark "Ready for review" when done to trigger full CI pipeline

How to convert:

1. Click "Still in progress? Convert to draft" in the sidebar, OR
2. Use gh pr ready when ready for review

This is just a friendly reminder - feel free to continue as is! 😊

[github-actions]

💡 Tip: Consider Using Draft PRs

Benefits of opening PRs as drafts initially:

• 💰 Saves CI runtime and Copilot review credits
• 🎯 Automatically sets linked issues to "🚧 In Progress" status
• 🚀 Mark "Ready for review" when done to trigger full CI pipeline

How to convert:

1. Click "Still in progress? Convert to draft" in the sidebar, OR
2. Use gh pr ready when ready for review

This is just a friendly reminder - feel free to continue as is! 😊