Skip to content

🔧 Improve pre-push error message for PR size violations #81

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 2, 2025
Merged

🔧 Improve pre-push error message for PR size violations #81

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 26 additions & 6 deletions scripts/preflight.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -270,18 +270,38 @@ else
echo "Preflight OK · Changed lines: 0 (after exclusions)"
exit 0
else
# Use --numstat for locale-independent parsing (sum insertions + deletions)
CHANGED=$(echo "$DIFF_OUTPUT" | awk '{ins+=$1; del+=$2} END {print ins+del+0}')
[ -z "$CHANGED" ] && CHANGED=0
# Use --numstat for locale-independent parsing
INSERTIONS=$(echo "$DIFF_OUTPUT" | awk '{ins+=$1} END {print ins+0}')
DELETIONS=$(echo "$DIFF_OUTPUT" | awk '{del+=$2} END {print del+0}')
CHANGED=$((INSERTIONS + DELETIONS))

if [ "$CHANGED" -gt 600 ]; then
# Check for override file (similar to GitHub label for exceptional cases)
if [ -f "$ROOT_DIR/.preflight-allow-large-pr" ]; then
echo "⚠️ Large PR override active ($CHANGED > 600 lines). Remove .preflight-allow-large-pr when done." >&2
else
echo "PR too large ($CHANGED > 600 lines). Please split into smaller slices." >&2
echo "Tip: Lock files and license files are already excluded. See .preflight-exclude for details." >&2
echo "For exceptional cases, create .preflight-allow-large-pr to override this check." >&2
echo "" >&2
echo "═══════════════════════════════════════════════════════════════" >&2
echo "❌ PRE-PUSH CHECK FAILED: PR TOO LARGE" >&2
echo "═══════════════════════════════════════════════════════════════" >&2
echo "" >&2
echo "Your changes: $CHANGED lines ($INSERTIONS insertions, $DELETIONS deletions)" >&2
echo "Maximum allowed: 600 lines per PR" >&2
echo "" >&2
echo "Action required: Split changes into smaller, focused PRs" >&2
echo "" >&2
echo "💡 Available options:" >&2
echo " 1. Split PR: Recommended approach" >&2
echo " 2. Override check: touch .preflight-allow-large-pr" >&2
echo " 3. Bypass hook: git push --no-verify (not recommended)" >&2
echo "" >&2
echo "Note: Lock files and license files are already excluded" >&2
echo " See .preflight-exclude for custom exclusion patterns" >&2
echo "" >&2
echo "═══════════════════════════════════════════════════════════════" >&2
echo "Push aborted. Fix the issue above and try again." >&2
echo "═══════════════════════════════════════════════════════════════" >&2
echo "" >&2
exit 2
fi
else
Expand Down