🔧 Remove --no-verify suggestion from error message #82
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
💡 Tip: Consider Using Draft PRsBenefits of opening PRs as drafts initially:
How to convert:
This is just a friendly reminder - feel free to continue as is! 😊 |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR simplifies the guidance provided when a large PR is detected by removing the suggestion to bypass the preflight check entirely using --no-verify, and adds clarification that the override option should only be used for exceptional cases.
Changes
- Removes the third option suggesting
git push --no-verifyas a way to bypass the preflight hook - Adds clarifying text "(for exceptional cases)" to the override check option to discourage routine use
- Replace bash-specific [[ =~ ]] with POSIX-compliant case statement - Combine multiple grep -v calls into single grep -Ev with pattern group - Use grep -m 1 for early termination (performance improvement) - Fix sed range calculation (UNRELEASED_END is relative, not absolute) - Add clarifying comments about CHANGELOG_EXEMPT_PREFIXES and case sync - Improve warning message with specific line count and non-blocking note - Extract filter logic to reusable filter_changelog_content() function Aligns api/scripts/preflight.sh with optimizations applied to frontend, contracts, and .github repositories per Copilot review feedback.
💡 Tip: Consider Using Draft PRsBenefits of opening PRs as drafts initially:
How to convert:
This is just a friendly reminder - feel free to continue as is! 😊 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
PR #81 included
--no-verifyas option 3, which violates Critical Rule #4: No Bypass.Copilot correctly flagged this in SecPal/.github#171, SecPal/frontend#56, SecPal/contracts#40.
Solution
Removed
--no-verifysuggestion. Only.preflight-allow-large-prremains as legitimate override.Follow-up to #81