fix: prevent race condition in analytics sync #108
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ytics - Clear pending syncTimeout at start of syncEvents() method - Prevents duplicate sync attempts when manual sync (e.g., handleOnline) is triggered - Add 2 new tests to verify: 1. Pending debounced sync is cancelled on manual sync 2. No duplicate syncs occur from race condition - Update comments to explain race condition prevention Fixes #104 Tests: - All 134 tests passing (2 new tests added for sync coordination) - TypeScript: 0 errors - ESLint: 0 warnings - Prettier: compliant - REUSE: compliant (3.3)
💡 Tip: Consider Using Draft PRsBenefits of opening PRs as drafts initially:
How to convert:
This is just a friendly reminder - feel free to continue as is! 😊 |
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a potential race condition where debounced sync operations could conflict with manual sync triggers. When the browser comes online or periodic sync fires, the manual syncEvents() call now cancels any pending debounced sync to prevent duplicate sync attempts.
Key Changes
- Added timeout cancellation logic at the start of
syncEvents()method - Added two comprehensive tests to verify the fix works correctly
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/lib/analytics.ts | Added logic to clear pending debounced sync timeout when manual sync is triggered, preventing duplicate sync attempts |
| src/lib/analytics.test.ts | Added two tests verifying that pending debounced syncs are properly cancelled and that no duplicate syncs occur |
💡 Tip: Consider Using Draft PRsBenefits of opening PRs as drafts initially:
How to convert:
This is just a friendly reminder - feel free to continue as is! 😊 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #104 - Clear pending debounced sync when manual sync is triggered