Skip to content

Conversation

@SlowSnowFox
Copy link
Contributor

test plan: tested on gke cluster

test plan: tested on gke cluster
@SecretiveShell
Copy link
Owner

Is there any reason for having the container repository / image tag in values.yaml? It would be great if there is a way to just reference the latest container version so I don't have to update this manually every time.

image:
repository: ghcr.io/secretiveshell/mcp-bridge/mcp-bridge
pullPolicy: Always
tag: 0.1.0
Copy link
Contributor Author

@SlowSnowFox SlowSnowFox Jan 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would be nice to have latest tag for this but saw that it's not there yet so harcoded version for now

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yea you can use yq to update the tag in values.yaml easily that’s how I handle it doing upgrades

@SlowSnowFox
Copy link
Contributor Author

whoops sry I forgot to acutally send my comments. So it's standard to have the container repository set as default. As for the tag it would be nice if we could maintain a latest tag. Note that all the values can be overwritten anyway by users so it's not like the chart becomes unusable should you forget to update.

@SecretiveShell SecretiveShell merged commit f9fed09 into SecretiveShell:master Jan 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants