Skip to content

fix foreign key serialization in _format_field_value #72

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 14, 2019
Merged

fix foreign key serialization in _format_field_value #72

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
55ca599
fix foreign key serialization in _format_field_value
amsan Dec 4, 2018
000fc16
Merge branch 'master' into fix/format_field_value_fk
Photonios Sep 14, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion psqlextra/compiler.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,6 @@
from django.core.exceptions import SuspiciousOperation
from django.db.models import Model
from django.db.models.fields.related import RelatedField
from django.db.models.sql.compiler import SQLInsertCompiler, SQLUpdateCompiler

from psqlextra.expressions import HStoreValue
Expand Down Expand Up @@ -305,6 +307,10 @@ def _format_field_value(self, field_name) -> str:
field_name = self._normalize_field_name(field_name)
field = self._get_model_field(field_name)

value = getattr(self.query.objs[0], field.attname)
if isinstance(field, RelatedField) and isinstance(value, Model):
value = value.pk

return SQLInsertCompiler.prepare_value(
self,
field,
Expand All @@ -313,7 +319,7 @@ def _format_field_value(self, field_name) -> str:
# value. We rely on pre_save having already been done by the
# underlying compiler so that things like FileField have already had
# the opportunity to save out their data.
getattr(self.query.objs[0], field.attname),
value,
)

def _normalize_field_name(self, field_name) -> str:
Expand Down