refactor: GonghakRepository 리팩토링 #59
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- GonghakCorusesDao -> GonghakCoursesDao (Course 오타 수정) - JPQL에 사용된 CompletedCourseesDomain의 약어를 GCCD에서 CCD로 변경
gmltn9233
approved these changes
Aug 16, 2024
Contributor
gmltn9233
left a comment
gmltn9233
left a comment
There was a problem hiding this comment.
확실히 가독성이 좋아졌네요 좋습니다!!👍
Contributor
|
findUserCoursesByMajorByGonghakCoursesWithoutCompleteCourses -> findUserInCompletedCourses 특히 위와 같은 변수명 처치곤란이었는데 잘 줄여주셔서 감사합니다...ㅠㅠ |
jiseop121
approved these changes
Aug 17, 2024
Contributor
Author
|
감사합니다 ㅎㅎ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔧연결된 이슈
🛠️작업 내용
GonghakRepository의 메서드 이름 간소화GonghakCoursesDaoJPQL 메서드 이름 간소화 및CompletedCourseDomain별칭 수정(GCCD->CCD)GonghakCoursesDao클래스 이름 오타 수정GonghakCoursesDao에서 사용하지 않는 메서드 삭제🤷♂️PR이 필요한 이유
GonghakCoursesDao의 메서드는 현재 JPQL을 사용한 쿼리 메서드를 갖고 있습니다.해당 JPQL을 통해 쿼리 메서드가 어떠한 조건으로 데이터를 불러오고 있는지 충분히 보여주고 있다고 생각했습니다.
결국, 사용자가 이수하거나 이수하지 않은 공학인증 과목을 가져오는 메서드이기에 좀 더 직관적인 이름을 부여함과 동시에
메서드의 길이를 줄이는게 코드를 읽는데에도 더 편리할 것 같아서 메서드 이름을 다음과 같이 수정하였습니다.
findUserCoursesByMajorByGonghakCoursesWithCompletedCourses->findUserCompletedCoursesfindUserCoursesByMajorByGonghakCoursesWithoutCompleteCourses->findUserInCompletedCourses✔️PR 체크리스트