refactor: 결과표에 있는 영역 이름을 한글로 변경 #67
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
결과화면에 AbeekType의 typeMessage가 표시되도록 변경함
whxogus215
reviewed
Sep 3, 2024
Contributor
whxogus215
left a comment
whxogus215
left a comment
There was a problem hiding this comment.
ResultRatio와 RecommedCourse의 폰트가 주는 차별점이 확실히 있는 것 같아요! 그래서 저는 표 상단에 위치한 레이블은 영어로 두는게 좋은 것 같습니다.
Contributor
|
AbeekType은 한글로 변경한게 훨씬 가독성이 좋은 것 같습니다! 고생했습니다👍 |
whxogus215
approved these changes
Sep 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔧연결된 이슈
🛠️작업 내용
AbeekType의 typeMessage가 표시되도록 변경함h3에서h2로 변경🤷♂️PR이 필요한 이유
사용자에게 익숙한 영역 이름을 한글로 매칭시켜 인식하기 쉽게 변경했습니다.
AbeekType을 한글로 변경하다 보니, 기존의
Result Ratio,RECOMMEND COURSES문구도 한글로 바꿔볼까 생각이 들었는데, 모두 한글이면 조금 밋밋한 느낌도 있는것 같아 아직은 수정하지 않았습니다. 이에 의견 부탁드립니다.✔️PR 체크리스트