Add NodeFirefoxNightly image #470
Conversation
|
Hi @smccarthy , I'd love to use this image ( due to mozilla/geckodriver#858 ), but I'm getting following error when building it: Were you able to build this image on docker hub? EDIT: Ok it seems that DockerFile was generated badly for me. If anyone wants to give this a try: https://hub.docker.com/r/cvakiitho/firefox/ (ugh, node-base now has config generate in /opt/bin instead of /opt/selenium, fix is making its way into my image, but docker hub is now not building anything...) |
|
Hi @smccarthy, I am sorry that time passed and we didn't give you feedback. In general, it is a good idea to have the nightly FF as an option. Nevertheless it is not optimal to add one image more to maintain. Do you think that it is possible to make this work with the current Dockerfile for FF? Perhaps to have it working in the same way as the one for Chrome, where one can just specify the version as a parameter (such as google-chrome-beta) and then the image gets built. Let me know your thoughts, |
|
@diemol I like that idea. That was actually the feedback I got on Slack when I first opened this PR, but I haven't had the time to update the PR. Maybe this week. |
| RUN apt-get update -qqy \ | ||
| RUN FIREFOX_DOWNLOAD_URL=$(if [ $FIREFOX_VERSION = "nightly" ]; then echo "https://download.mozilla.org/?product=firefox-nightly-latest-ssl&os=linux64&lang=en-US"; else echo "https://download-installer.cdn.mozilla.net/pub/firefox/releases/$FIREFOX_VERSION/linux-x86_64/en-US/firefox-$FIREFOX_VERSION.tar.bz2"; fi) \ | ||
| && apt-get update -qqy \ | ||
| && apt-get -qqy --no-install-recommends install firefox \ |
There was a problem hiding this comment.
I noticed this in there. Is this needed if we get Firefox from Mozilla directly ?
Makefile
Outdated
| cd ./NodeFirefoxDebug && docker build $(BUILD_ARGS) -t $(NAME)/node-firefox-debug:$(VERSION) . | ||
|
|
||
| tag_nightly: | ||
| docker tag $(NAME)/node-firefox:$(VERSION) $(NAME)/node-firefox:nightly |
There was a problem hiding this comment.
Can I delete this tag if I call docker build with -t on line 59?
4 participants
Xin the preceding checkbox, I verify that I have signed the Contributor License AgreementI get the latest Firefox nightly image, and I also get the latest geckodriver too. I didn't know if it would be best to get the latest GeckoDriver, or have it set in the Dockerfile.
If this is wanted, I could also add the a standalone, standalone debug, and node debug image for nightly as well.