Skip to content

Conversation

@bonigarcia
Copy link
Member

Description

This PR adds the flags -Ctarget-feature=+crt-static to build SM in Windows and macOS. They are not required in Linux since we use target x86_64-unknown-linux-musl, which already provides static linking.

Motivation and Context

To avoid problems like the reported in #13261.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have read the contributing document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@bonigarcia bonigarcia added B-build Includes scripting, bazel and CI integrations C-rust Rust code is mostly Selenium Manager labels Dec 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

B-build Includes scripting, bazel and CI integrations C-rust Rust code is mostly Selenium Manager

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants