Skip to content

[java] Fix SpotBugs findings in ChromiumDriver and PortProber #14589

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 14, 2024
Merged

[java] Fix SpotBugs findings in ChromiumDriver and PortProber #14589

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0ebda01
[java] fix ChromiumDriver and PortProber
mk868 Oct 11, 2024
a594ed8
Merge branch 'trunk' into fix-ChromiumDriver-and-PortProber
pujagani Oct 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion java/src/org/openqa/selenium/chromium/ChromiumDriver.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -212,7 +212,8 @@ public ScriptKey pin(String script) {
// Create the actual script we're going to use.
String scriptToUse =
String.format(
"window.seleniumPinnedScript%s = function(){%s}", Math.abs(script.hashCode()), script);
"window.seleniumPinnedScript%s = function(){%s}",
Math.abs((long) script.hashCode()), script);

DevTools devTools = getDevTools();
devTools.createSessionIfThereIsNotOne();
Expand Down
2 changes: 1 addition & 1 deletion java/src/org/openqa/selenium/net/PortProber.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,7 +119,7 @@ private static boolean isFree(String bindHost, int port) {
socket.setReuseAddress(true);
socket.bind(new InetSocketAddress(bindHost, port));
return true;
} catch (Exception e) {
} catch (IOException | RuntimeException e) {
return false;
}
}
Expand Down
Loading