Skip to content

[py] Fixed Flaky Bidi Test #14701

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Nov 2, 2024
Merged

[py] Fixed Flaky Bidi Test #14701

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
f2998b1
[py] Fixed Flaky Bidi Test
shbenzer Nov 1, 2024
334a0bd
Merge branch 'trunk' into fix-flaky-bidi-test
shbenzer Nov 1, 2024
82ab23d
linting
shbenzer Nov 2, 2024
60fd000
removed unused import
shbenzer Nov 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions py/test/selenium/webdriver/common/bidi_tests.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,6 @@

from selenium.webdriver.common.by import By
from selenium.webdriver.common.log import Log
from selenium.webdriver.support import expected_conditions as EC
from selenium.webdriver.support.ui import WebDriverWait


Expand Down Expand Up @@ -76,8 +75,6 @@ async def test_collect_log_mutations(driver, pages):
WebDriverWait(driver, 10).until(
lambda d: d.find_element(By.ID, "revealed").value_of_css_property("display") != "none"
)
WebDriverWait(driver, 5).until(EC.visibility_of(driver.find_element(By.ID, "revealed")))

assert event["attribute_name"] == "style"
assert event["current_value"] == ""
assert event["old_value"] == "display:none;"
Loading