Skip to content

[py] Moved Rust binary settings to pyproject.toml from setup.py #14837

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Dec 5, 2024
Merged

[py] Moved Rust binary settings to pyproject.toml from setup.py #14837

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
477d4ce
Moved Rust binary settings to pyproject.toml from setup.py
sandeepsuryaprasad Nov 30, 2024
17b8bd3
Merge branch 'trunk' into setup
VietND96 Dec 2, 2024
045ab3b
Update Rakefile to remove py/setup.py
VietND96 Dec 4, 2024
4b69c4b
Merge remote-tracking branch 'origin/trunk' into setup
VietND96 Dec 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 1 addition & 4 deletions Rakefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -585,8 +585,7 @@ namespace :py do
nightly = ".#{Time.now.strftime('%Y%m%d%H%M')}"
new_version = updated_version(old_version, arguments[:version], nightly)

['py/setup.py',
'py/pyproject.toml',
['py/pyproject.toml',
'py/BUILD.bazel',
'py/selenium/__init__.py',
'py/selenium/webdriver/__init__.py',
Expand Down Expand Up @@ -1048,7 +1047,6 @@ namespace :all do
'py/selenium/webdriver/__init__.py',
'py/selenium/__init__.py',
'py/BUILD.bazel',
'py/setup.py',
'rb/lib/selenium/webdriver/version.rb',
'rb/Gemfile.lock'])

Expand Down Expand Up @@ -1110,7 +1108,6 @@ namespace :all do
'py/selenium/webdriver/__init__.py',
'py/BUILD.bazel',
'py/CHANGES',
'py/setup.py',
'rb/lib/selenium/webdriver/version.rb',
'rb/CHANGES',
'rb/Gemfile.lock',
Expand Down
1 change: 0 additions & 1 deletion py/BUILD.bazel
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -231,7 +231,6 @@ pkg_files(
"CHANGES",
"README.rst",
"pyproject.toml",
"setup.py",
":license",
":selenium-pkg",
":selenium-pkginfo",
Expand Down
3 changes: 3 additions & 0 deletions py/pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,9 @@ exclude = ["test*"]
namespaces = false
# include-package-data is `true` by default in pyproject.toml

[[tool.setuptools-rust.bins]]
target = "selenium.webdriver.common.selenium-manager"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should have been:

[[tool.setuptools-rust.ext-modules]]
target = "selenium.webdriver.common.selenium-manager"
binding = "Exec"

Fixed in #16074.


[project.urls]
Repository = "https://github.com/SeleniumHQ/selenium/"
BugTracker = "https://github.com/SeleniumHQ/selenium/issues"
Expand Down
38 changes: 0 additions & 38 deletions py/setup.py
View file
Open in desktop

This file was deleted.

Loading