Skip to content

[dotnet] Correct assertion of struct type in internal tests #14878

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 19, 2024
Merged

[dotnet] Correct assertion of struct type in internal tests #14878

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2709d08
[dotnet] Complete NUnit 4 future-proofing
RenderMichael Dec 9, 2024
533aa5a
Merge branch 'trunk' into nunit-4
nvborisenko Dec 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions dotnet/test/common/DevTools/DevToolsProfilerTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,12 +131,12 @@ private void ValidateProfile(CurrentCdpVersion.Profiler.Profile profiler)
{
Assert.That(profiler, Is.Not.Null);
Assert.That(profiler.Nodes, Is.Not.Null);
Assert.That(profiler.StartTime, Is.Not.Null);
Assert.That(profiler.EndTime, Is.Not.Null);
Assert.That(profiler.StartTime, Is.Not.Zero);
Assert.That(profiler.EndTime, Is.Not.Zero);
Assert.That(profiler.TimeDeltas, Is.Not.Null);
foreach (var delta in profiler.TimeDeltas)
{
Assert.That(delta, Is.Not.Null);
Assert.That(delta, Is.Not.Zero);
}

foreach (var node in profiler.Nodes)
Expand Down
2 changes: 1 addition & 1 deletion dotnet/test/common/DevTools/DevToolsTestFixture.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ public void Setup()
devTools = driver as IDevTools;
if (devTools == null)
{
Assert.Ignore("{0} does not support Chrome DevTools Protocol", EnvironmentManager.Instance.Browser);
Assert.Ignore($"{EnvironmentManager.Instance.Browser} does not support Chrome DevTools Protocol");
return;
}

Expand Down