Skip to content

[dotnet] Add readable timestamps to log in Chromium browsers #16133

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 5, 2025
Merged

[dotnet] Add readable timestamps to log in Chromium browsers #16133

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fbce035
[dotnet] Add readable timestamps to log in Chromium browsers
diemol Aug 5, 2025
872e558
Format script
diemol Aug 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions dotnet/src/webdriver/Chromium/ChromiumDriverService.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,6 +95,11 @@ protected ChromiumDriverService(string? executablePath, string? executableFileNa
/// </summary>
public string? AllowedIPAddresses { get; set; }

/// <summary>
/// Adds readable timestamps to log
/// </summary>
public bool ReadableTimestamp { get; set; }
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kind of optional argument, would be nice to convert it to nullable bool?. Yes, it doesn't follow existing pattern, but improving old API is a breaking change.

Contributes to: #14640


/// <summary>
/// Gets the command-line arguments for the driver service.
/// </summary>
Expand Down Expand Up @@ -128,6 +133,11 @@ protected override string CommandLineArguments
argsBuilder.Append(" --append-log");
}

if (this.ReadableTimestamp)
{
argsBuilder.Append(" --readable-timestamp");
}

if (!string.IsNullOrEmpty(this.LogPath))
{
argsBuilder.AppendFormat(CultureInfo.InvariantCulture, " --log-path=\"{0}\"", this.LogPath);
Expand Down
Loading