Skip to content

Rack 3.x compatibility #16158

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: trunk
Choose a base branch
from
+6 −2
Open

Rack 3.x compatibility #16158

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
027eb7a
Use `Rack::Files` for Rack 3+ compatibility
voxik Aug 8, 2025
f470b1c
Use `Rackup::Handler` when available
voxik Aug 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions rb/spec/integration/selenium/webdriver/spec_support/rack_server.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,10 @@
# under the License.

require 'rack'
begin
require 'rackup'
rescue LoadError
end

module Selenium
module WebDriver
Expand Down Expand Up @@ -76,7 +80,7 @@ def handler

handler = handlers.find { |h| load_handler h }
constant = handler == 'webrick' ? 'WEBrick' : handler.capitalize
Rack::Handler.const_get constant
(defined?(Rackup) ? Rackup : Rack)::Handler.const_get(constant)
end

def load_handler(handler)
Expand All @@ -100,7 +104,7 @@ class TestApp
BASIC_AUTH_CREDENTIALS = %w[test test].freeze

def initialize(file_root)
@static = Rack::File.new(file_root)
@static = Rack::Files.new(file_root)
end

def call(env)
Expand Down
Loading