Skip to content

[py][bidi]: enable history_updated event test #16236

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 25, 2025
Merged

[py][bidi]: enable history_updated event test #16236

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ab70b15
enable `test_add_event_handler_history_updated` test
navin772 Aug 22, 2025
1ed0b66
change to url
navin772 Aug 22, 2025
e0e9c0d
Merge branch 'trunk' into enable-history-updated-test-py
navin772 Aug 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 5 additions & 7 deletions py/test/selenium/webdriver/common/bidi_browsing_context_tests.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -756,9 +756,6 @@ def on_user_prompt_closed(info):
driver.browsing_context.remove_event_handler("user_prompt_closed", callback_id)


@pytest.mark.xfail_chrome
@pytest.mark.xfail_firefox
@pytest.mark.xfail_edge
def test_add_event_handler_history_updated(driver, pages):
"""Test adding event handler for history_updated event."""
events_received = []
Expand All @@ -769,16 +766,17 @@ def on_history_updated(info):
callback_id = driver.browsing_context.add_event_handler("history_updated", on_history_updated)
assert callback_id is not None

# Navigate to a page and use history API to trigger the event
context_id = driver.current_window_handle
url = pages.url("simpleTest.html")
driver.browsing_context.navigate(context=context_id, url=url, wait=ReadinessState.COMPLETE)

# Use history.pushState to trigger history updated event
driver.execute_script("history.pushState({}, '', '/new-path');")
driver.script.execute("() => { history.pushState({}, '', '/new-path'); }")
WebDriverWait(driver, 5).until(lambda d: len(events_received) > 0)

assert len(events_received) == 1
assert any("/new-path" in event.url for event in events_received)
assert len(events_received) >= 1
assert "/new-path" in events_received[0].url
assert events_received[0].context == context_id

driver.browsing_context.remove_event_handler("history_updated", callback_id)

Expand Down
Loading