Skip to content

Conversation

@titusfortner
Copy link
Member

@titusfortner titusfortner commented Oct 23, 2025

User description

This will tell you which bazel tags are being used by this project right now:

bazel query 'attr(tags, .*, tests(//...))' --output=build \ 
  | grep 'tags' \
  | sed -E 's/.*tags *= *\[//; s/\].*//; s/"//g; s/,/ /g' \
  | tr ' ' '\n' \
  | grep -v '^$' \
  | sort -u

Using this is deceptive because it is grabbing targets that include 'remote' in the tag:

 bazel query 'attr("tags","remote", tests(//rb/...))'

The point being that there is no reason to filter a tag that we're not using anywhere because it only confuses people


PR Type

Enhancement


Description

  • Remove unused -remote tag filter from RBE test configuration

  • Simplify test tag filtering to only exclude -skip-rbe tag

  • Reduce configuration complexity by eliminating non-functional filter


Diagram Walkthrough

flowchart LR
  A["test:rbe config"] -->|"remove -remote filter"| B["simplified tag filters"]
  B -->|"keep only"| C["-skip-rbe filter"]
Loading

File Walkthrough

Relevant files
Configuration changes
.bazelrc.remote
Remove unused -remote tag filter from RBE config                 

.bazelrc.remote

  • Removed -remote tag from test_tag_filters in the test:rbe
    configuration
  • Kept -skip-rbe tag filter as the only exclusion criterion
  • Simplified test filtering logic by removing unused tag reference
+1/-1     

@qodo-merge-pro
Copy link
Contributor

PR Compliance Guide 🔍

Below is a summary of compliance checks for this PR:

Security Compliance
🟢
No security concerns identified No security vulnerabilities detected by AI analysis. Human verification advised for critical code.
Ticket Compliance
🎫 No ticket provided
- [ ] Create ticket/issue <!-- /create_ticket --create_ticket=true -->

</details></td></tr>
Codebase Duplication Compliance
Codebase context is not defined

Follow the guide to enable codebase context checks.

Custom Compliance
No custom compliance provided

Follow the guide to enable custom compliance check.

Compliance status legend 🟢 - Fully Compliant
🟡 - Partial Compliant
🔴 - Not Compliant
⚪ - Requires Further Human Verification
🏷️ - Compliance label

@selenium-ci selenium-ci added the B-build Includes scripting, bazel and CI integrations label Oct 23, 2025
@qodo-merge-pro
Copy link
Contributor

PR Code Suggestions ✨

No code suggestions found for the PR.

@titusfortner titusfortner merged commit e51fca1 into trunk Oct 23, 2025
21 checks passed
@titusfortner titusfortner deleted the build_remote branch October 23, 2025 15:00
This was referenced Oct 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

B-build Includes scripting, bazel and CI integrations Review effort 1/5

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants