-
-
Notifications
You must be signed in to change notification settings - Fork 8.6k
[build] removing test_tag_filter tag that isn't being used anywhere #16496
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR Compliance Guide 🔍Below is a summary of compliance checks for this PR:
Compliance status legend🟢 - Fully Compliant🟡 - Partial Compliant 🔴 - Not Compliant ⚪ - Requires Further Human Verification 🏷️ - Compliance label |
||||||||||||||||||
PR Code Suggestions ✨No code suggestions found for the PR. |
This was referenced Oct 25, 2025
This was referenced Oct 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
User description
This will tell you which bazel tags are being used by this project right now:
Using this is deceptive because it is grabbing targets that include 'remote' in the tag:
The point being that there is no reason to filter a tag that we're not using anywhere because it only confuses people
PR Type
Enhancement
Description
Remove unused
-remotetag filter from RBE test configurationSimplify test tag filtering to only exclude
-skip-rbetagReduce configuration complexity by eliminating non-functional filter
Diagram Walkthrough
File Walkthrough
.bazelrc.remote
Remove unused -remote tag filter from RBE config.bazelrc.remote
-remotetag fromtest_tag_filtersin thetest:rbeconfiguration
-skip-rbetag filter as the only exclusion criterion