-
-
Couldn't load subscription status.
- Fork 8.6k
[dotnet] switch tests back to v141 until v142 is released #16510
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: trunk
Are you sure you want to change the base?
Conversation
PR Compliance Guide 🔍Below is a summary of compliance checks for this PR:
Compliance status legend🟢 - Fully Compliant🟡 - Partial Compliant 🔴 - Not Compliant ⚪ - Requires Further Human Verification 🏷️ - Compliance label |
||||||||||||||||||
PR Code Suggestions ✨Explore these optional code suggestions:
|
||||||||||||
CI Feedback 🧐A test triggered by this PR failed. Here is an AI-generated analysis of the failure:
|
|
|
||
| if channel == "Stable": | ||
| dir_path = root_dir / "dotnet/test/common/DevTools" | ||
| for file in dir_path.glob("*") if file.is_file() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is that valid syntax?
I'd write that as:
for file in dir_path.glob("*"):
if file.is_file():
User description
I tried tricking dotnet and Java to use chrome_beta instead of chrome for driver & browser locations while we are using "early release" (beta version). It worked for .NET but made Java unhappy, and I'm not sure the right thing to do here. Ideally we want to test the new CDP version, but we also don't want failing tests. What do you think @nvborisenko ?
I think this CDP code would work to check the channel and only update the test files if it is the stable channel. @cgoldberg does this python logic look right? I'm not sure we actually want to do it, though.
PR Type
Bug fix, Tests
Description
Revert .NET DevTools tests to CDP v141 from v142
Add conditional logic to only update test files on stable Chrome channel
Prevent test failures during beta/early release versions
Diagram Walkthrough
File Walkthrough
8 files
Revert CDP version from v142 to v141Revert CDP version from v142 to v141Revert CDP version from v142 to v141Revert CDP version from v142 to v141Revert CDP version from v142 to v141Revert CDP version from v142 to v141Revert CDP version from v142 to v141Revert CDP version and id from v142 to v1411 files
Add channel detection and conditional test file updates