Skip to content

[grid] Update container label compose.oneoff in Dynamic Grid #16613

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 19, 2025
+5 −1
Merged

[grid] Update container label compose.oneoff in Dynamic Grid #16613

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fd8260c
[grid] Update container label `compose.oneoff` in Dynamic Grid
VietND96 Nov 19, 2025
f7e0af3
Fix review comment
VietND96 Nov 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion java/src/org/openqa/selenium/grid/node/docker/DockerSessionFactory.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -141,7 +141,11 @@ public DockerSessionFactory(
this.predicate = Require.nonNull("Accepted capabilities predicate", predicate);
this.hostConfig = Require.nonNull("Container host config", hostConfig);
this.hostConfigKeys = Require.nonNull("Browser container host config keys", hostConfigKeys);
this.composeLabels = Require.nonNull("Docker Compose labels", composeLabels);
// Merge compose labels with oneoff=False to prevent triggering --exit-code-from dynamic grid
Map<String, String> allLabels =
new HashMap<>(Require.nonNull("Docker Compose labels", composeLabels));
allLabels.put("com.docker.compose.oneoff", "False");
this.composeLabels = Collections.unmodifiableMap(allLabels);
}

@Override
Expand Down
Loading