Skip to content

Conversation

@selenium-ci
Copy link
Member

@selenium-ci selenium-ci commented Nov 20, 2025

This is an automated pull request to update pinned browsers and drivers

Merge after verify the new browser versions properly passing the tests and no bugs need to be filed

@selenium-ci selenium-ci added the B-build Includes scripting, bazel and CI integrations label Nov 20, 2025
@qodo-merge-pro
Copy link
Contributor

qodo-merge-pro bot commented Nov 20, 2025

PR Compliance Guide 🔍

Below is a summary of compliance checks for this PR:

Security Compliance
🟢
No security concerns identified No security vulnerabilities detected by AI analysis. Human verification advised for critical code.
Ticket Compliance
🎫 No ticket provided
  • Create ticket/issue
Codebase Duplication Compliance
Codebase context is not defined

Follow the guide to enable codebase context checks.

Custom Compliance
🟢
Generic: Comprehensive Audit Trails

Objective: To create a detailed and reliable record of critical system actions for security analysis
and compliance.

Status: Passed

Learn more about managing compliance generic rules or creating your own custom rules

Generic: Meaningful Naming and Self-Documenting Code

Objective: Ensure all identifiers clearly express their purpose and intent, making code
self-documenting

Status: Passed

Learn more about managing compliance generic rules or creating your own custom rules

Generic: Robust Error Handling and Edge Case Management

Objective: Ensure comprehensive error handling that provides meaningful context and graceful
degradation

Status: Passed

Learn more about managing compliance generic rules or creating your own custom rules

Generic: Secure Error Handling

Objective: To prevent the leakage of sensitive system information through error messages while
providing sufficient detail for internal debugging.

Status: Passed

Learn more about managing compliance generic rules or creating your own custom rules

Generic: Secure Logging Practices

Objective: To ensure logs are useful for debugging and auditing without exposing sensitive
information like PII, PHI, or cardholder data.

Status: Passed

Learn more about managing compliance generic rules or creating your own custom rules

Generic: Security-First Input Validation and Data Handling

Objective: Ensure all data inputs are validated, sanitized, and handled securely to prevent
vulnerabilities

Status: Passed

Learn more about managing compliance generic rules or creating your own custom rules

  • Update
Compliance status legend 🟢 - Fully Compliant
🟡 - Partial Compliant
🔴 - Not Compliant
⚪ - Requires Further Human Verification
🏷️ - Compliance label

@qodo-merge-pro
Copy link
Contributor

qodo-merge-pro bot commented Nov 20, 2025

PR Code Suggestions ✨

Explore these optional code suggestions:

CategorySuggestion                                                                                                                                    Impact
Possible issue
Correct inconsistent driver version downgrade

Revert the mac_edgedriver version downgrade to 142.0.3595.80 and use version
142.0.3595.90 to match the linux_edgedriver update and prevent platform-specific
bugs.

common/repositories.bzl [183-198]

 http_archive(
     name = "mac_edgedriver",
-    url = "https://msedgedriver.microsoft.com/142.0.3595.80/edgedriver_mac64.zip",
-    sha256 = "d090832bed7018617d2252618c6355bd258861de94fcd70e0e300c13e91fe67e",
+    url = "https://msedgedriver.microsoft.com/142.0.3595.90/edgedriver_mac64.zip",
+    sha256 = "0c3a94f2a4dde3f0596bda3f7319966572db5826724f051c8e5b857cc772e5df",
     build_file_content = """
 load("@aspect_rules_js//js:defs.bzl", "js_library")
 package(default_visibility = ["//visibility:public"])
 
 exports_files(["msedgedriver"])
 
 js_library(
     name = "msedgedriver-js",
     data = ["msedgedriver"],
 )
 """,
 )
  • Apply / Chat
Suggestion importance[1-10]: 10

__

Why: The suggestion correctly identifies a critical inconsistency where the mac_edgedriver is downgraded while the linux_edgedriver is upgraded, which is almost certainly an error that would cause platform-specific failures.

High
Learned
best practice
Centralize version into variable

Centralize the version into a single variable and interpolate it into URLs to
prevent inconsistencies between platforms when updating.

common/repositories.bzl [51-94]

+FIREFOX_BETA_VERSION = "146.0b5"
+
 dmg_archive(
     name = "mac_beta_firefox",
-    url = "https://ftp.mozilla.org/pub/firefox/releases/146.0b5/mac/en-US/Firefox%20146.0b5.dmg",
+    url = "https://ftp.mozilla.org/pub/firefox/releases/%s/mac/en-US/Firefox%%20%s.dmg" % (FIREFOX_BETA_VERSION, FIREFOX_BETA_VERSION),
     sha256 = "4821a9980b24264d02f1b97d083ecd177616f19f7a00adfcbd2e40d7053dfe42",
     build_file_content = """
 load("@aspect_rules_js//js:defs.bzl", "js_library")
 package(default_visibility = ["//visibility:public"])
 
 ...
 """,
 )
 
 http_archive(
     name = "linux_beta_firefox",
-    url = "https://ftp.mozilla.org/pub/firefox/releases/146.0b5/linux-x86_64/en-US/firefox-146.0b5.tar.xz",
+    url = "https://ftp.mozilla.org/pub/firefox/releases/%s/linux-x86_64/en-US/firefox-%s.tar.xz" % (FIREFOX_BETA_VERSION, FIREFOX_BETA_VERSION),
     sha256 = "acc392fd3b9711d2ee749366f6adf86e38cba8e3dda6bd77cc01ad603f5a2418",
     build_file_content = """
 load("@aspect_rules_js//js:defs.bzl", "js_library")
 package(default_visibility = ["//visibility:public"])
 
 ...
 """,
 )

[To ensure code accuracy, apply this suggestion manually]

Suggestion importance[1-10]: 6

__

Why:
Relevant best practice - Clamp and validate externally-sourced version strings to consistent variables to avoid drift and mistakes across multiple archive rules.

Low
  • Update

@selenium-ci selenium-ci force-pushed the pinned-browser-updates branch from 223c227 to a30855a Compare November 21, 2025 00:41
@navin772 navin772 merged commit 5cc07f0 into trunk Nov 21, 2025
47 checks passed
@navin772 navin772 deleted the pinned-browser-updates branch November 21, 2025 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

B-build Includes scripting, bazel and CI integrations Review effort 1/5

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants