Skip to content

Conversation

@selenium-ci
Copy link
Member

@selenium-ci selenium-ci commented Nov 27, 2025

User description

This is an automated pull request to update pinned browsers and drivers

Merge after verify the new browser versions properly passing the tests and no bugs need to be filed


PR Type

Enhancement


Description

  • Update Firefox beta browser version from 146.0b7 to 146.0b8

  • Update Linux beta Firefox archive URL and SHA256 checksum

  • Update macOS beta Firefox archive URL and SHA256 checksum


Diagram Walkthrough

flowchart LR
  A["Firefox 146.0b7"] -- "Update to" --> B["Firefox 146.0b8"]
  B -- "Update URLs" --> C["Linux & macOS archives"]
  C -- "Update checksums" --> D["SHA256 hashes"]
Loading

File Walkthrough

Relevant files
Configuration changes
repositories.bzl
Update Firefox beta versions and checksums                             

common/repositories.bzl

  • Updated Linux beta Firefox URL from 146.0b7 to 146.0b8
  • Updated Linux beta Firefox SHA256 checksum
  • Updated macOS beta Firefox URL from 146.0b7 to 146.0b8
  • Updated macOS beta Firefox SHA256 checksum
+4/-4     

@selenium-ci selenium-ci added the B-build Includes scripting, bazel and CI integrations label Nov 27, 2025
@qodo-merge-pro
Copy link
Contributor

PR Compliance Guide 🔍

Below is a summary of compliance checks for this PR:

Security Compliance
🟢
No security concerns identified No security vulnerabilities detected by AI analysis. Human verification advised for critical code.
Ticket Compliance
🎫 No ticket provided
  • Create ticket/issue
Codebase Duplication Compliance
Codebase context is not defined

Follow the guide to enable codebase context checks.

Custom Compliance
🟢
Generic: Meaningful Naming and Self-Documenting Code

Objective: Ensure all identifiers clearly express their purpose and intent, making code
self-documenting

Status: Passed

Learn more about managing compliance generic rules or creating your own custom rules

Generic: Secure Logging Practices

Objective: To ensure logs are useful for debugging and auditing without exposing sensitive
information like PII, PHI, or cardholder data.

Status: Passed

Learn more about managing compliance generic rules or creating your own custom rules

Generic: Comprehensive Audit Trails

Objective: To create a detailed and reliable record of critical system actions for security analysis
and compliance.

Status:
No audit scope: The added lines only update URLs and checksums and do not pertain to critical actions or
logging, so audit trail compliance cannot be evaluated from this diff alone.

Referred Code
        url = "https://ftp.mozilla.org/pub/firefox/releases/146.0b8/linux-x86_64/en-US/firefox-146.0b8.tar.xz",
        sha256 = "fc48d01b966fd74419dc91d6ee5daeaa7db09c180c20b949360aac9975f369de",
        build_file_content = """
load("@aspect_rules_js//js:defs.bzl", "js_library")
package(default_visibility = ["//visibility:public"])

filegroup(
    name = "files",
    srcs = glob(["**/*"]),
)

exports_files(["firefox/firefox"])

js_library(
    name = "firefox-js",
    data = [":files"],
)
""",
    )

    dmg_archive(


 ... (clipped 3 lines)

Learn more about managing compliance generic rules or creating your own custom rules

Generic: Robust Error Handling and Edge Case Management

Objective: Ensure comprehensive error handling that provides meaningful context and graceful
degradation

Status:
No error paths: The changes only modify static artifact URLs and checksums without introducing code paths
where error handling would apply, so robustness cannot be assessed from this diff.

Referred Code
        url = "https://ftp.mozilla.org/pub/firefox/releases/146.0b8/linux-x86_64/en-US/firefox-146.0b8.tar.xz",
        sha256 = "fc48d01b966fd74419dc91d6ee5daeaa7db09c180c20b949360aac9975f369de",
        build_file_content = """
load("@aspect_rules_js//js:defs.bzl", "js_library")
package(default_visibility = ["//visibility:public"])

filegroup(
    name = "files",
    srcs = glob(["**/*"]),
)

exports_files(["firefox/firefox"])

js_library(
    name = "firefox-js",
    data = [":files"],
)
""",
    )

    dmg_archive(


 ... (clipped 3 lines)

Learn more about managing compliance generic rules or creating your own custom rules

Generic: Secure Error Handling

Objective: To prevent the leakage of sensitive system information through error messages while
providing sufficient detail for internal debugging.

Status:
No user errors: The diff only updates dependency URLs and checksums and does not introduce user-facing
error messages, so secure error handling cannot be evaluated here.

Referred Code
        url = "https://ftp.mozilla.org/pub/firefox/releases/146.0b8/linux-x86_64/en-US/firefox-146.0b8.tar.xz",
        sha256 = "fc48d01b966fd74419dc91d6ee5daeaa7db09c180c20b949360aac9975f369de",
        build_file_content = """
load("@aspect_rules_js//js:defs.bzl", "js_library")
package(default_visibility = ["//visibility:public"])

filegroup(
    name = "files",
    srcs = glob(["**/*"]),
)

exports_files(["firefox/firefox"])

js_library(
    name = "firefox-js",
    data = [":files"],
)
""",
    )

    dmg_archive(


 ... (clipped 3 lines)

Learn more about managing compliance generic rules or creating your own custom rules

Generic: Security-First Input Validation and Data Handling

Objective: Ensure all data inputs are validated, sanitized, and handled securely to prevent
vulnerabilities

Status:
External artifact: The new external archive URLs and checksums are updated, but the diff does not show
validation or verification logic beyond the provided sha256 fields, so overall input
handling cannot be fully assessed.

Referred Code
        url = "https://ftp.mozilla.org/pub/firefox/releases/146.0b8/linux-x86_64/en-US/firefox-146.0b8.tar.xz",
        sha256 = "fc48d01b966fd74419dc91d6ee5daeaa7db09c180c20b949360aac9975f369de",
        build_file_content = """
load("@aspect_rules_js//js:defs.bzl", "js_library")
package(default_visibility = ["//visibility:public"])

filegroup(
    name = "files",
    srcs = glob(["**/*"]),
)

exports_files(["firefox/firefox"])

js_library(
    name = "firefox-js",
    data = [":files"],
)
""",
    )

    dmg_archive(


 ... (clipped 3 lines)

Learn more about managing compliance generic rules or creating your own custom rules

Compliance status legend 🟢 - Fully Compliant
🟡 - Partial Compliant
🔴 - Not Compliant
⚪ - Requires Further Human Verification
🏷️ - Compliance label

@qodo-merge-pro
Copy link
Contributor

PR Code Suggestions ✨

Explore these optional code suggestions:

CategorySuggestion                                                                                                                                    Impact
General
Use a variable for versioning

To improve maintainability, define the Firefox beta version in a variable and
use it to construct the download URLs, thus avoiding hardcoded and duplicated
version strings.

common/repositories.bzl [51-76]

+_FIREFOX_BETA_VERSION = "146.0b8"
+
 http_archive(
     name = "linux_beta_firefox",
-    url = "https://ftp.mozilla.org/pub/firefox/releases/146.0b8/linux-x86_64/en-US/firefox-146.0b8.tar.xz",
+    url = "https://ftp.mozilla.org/pub/firefox/releases/{v}/linux-x86_64/en-US/firefox-{v}.tar.xz".format(v = _FIREFOX_BETA_VERSION),
     sha256 = "fc48d01b966fd74419dc91d6ee5daeaa7db09c180c20b949360aac9975f369de",
     ...
 )
 
 dmg_archive(
     name = "mac_beta_firefox",
-    url = "https://ftp.mozilla.org/pub/firefox/releases/146.0b8/mac/en-US/Firefox%20146.0b8.dmg",
+    url = "https://ftp.mozilla.org/pub/firefox/releases/{v}/mac/en-US/Firefox%20{v}.dmg".format(v = _FIREFOX_BETA_VERSION),
     sha256 = "27e5293fb36fcbe52a83f8962e7b3f52d9a3ef30a5d4a8b8d5e891b81c02ef4b",
     ...
 )

[To ensure code accuracy, apply this suggestion manually]

Suggestion importance[1-10]: 6

__

Why: The suggestion correctly identifies hardcoded version strings and proposes refactoring to use a variable, which significantly improves maintainability for future updates.

Low
  • More

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

B-build Includes scripting, bazel and CI integrations Review effort 1/5

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants