Skip to content

[py] Add --selenium-version to Selenium Manager args #16659

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
cgoldberg wants to merge 1 commit into
base: trunk
Choose a base branch
from
Open

[py] Add --selenium-version to Selenium Manager args #16659

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion py/selenium/webdriver/common/selenium_manager.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@
# KIND, either express or implied. See the License for the
# specific language governing permissions and limitations
# under the License.

import json
import logging
import os
Expand All @@ -24,6 +25,8 @@
from pathlib import Path

from selenium.common import WebDriverException
from selenium.webdriver import __version__ as VERSION


logger = logging.getLogger(__name__)

Expand All @@ -35,7 +38,7 @@ class SeleniumManager:
"""

def binary_paths(self, args: list) -> dict:
"""Determines the locations of the requested assets.
"""Builds the Selenium Manager command line argument list and runs it.

Args:
args: the commands to send to the selenium manager binary.
Expand All @@ -48,6 +51,8 @@ def binary_paths(self, args: list) -> dict:
args.append("--debug")
args.append("--language-binding")
args.append("python")
args.append("--selenium-version")
args.append(VERSION)
args.append("--output")
args.append("json")

Expand Down
Loading