Skip to content

Conversation

Copy link
Contributor

Copilot AI commented Dec 2, 2025

Thanks for the feedback on #5. I've created this new PR, which merges into #5, to address your comment. I will work on the changes and keep this PR's description up to date as I make progress.

Original PR: #5
Triggering review: #5 (comment)

@copilot open a new pull request to apply changes based on this feedback


✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

@OhYee
Copy link
Contributor

OhYee commented Dec 2, 2025

In an async test method, Credential.create() should be replaced with await Credential.create_async() to maintain consistency with the async pattern used elsewhere in the test (e.g., await ModelService.create_async(), await ms.delete_async(), await cr.delete_async()). Using synchronous calls in async methods can lead to blocking behavior and defeats the purpose of async testing.

@OhYee OhYee closed this Dec 2, 2025
Copilot AI requested a review from OhYee December 2, 2025 03:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants