JAV-524 Optimize edge executor#297
Merged
liubao68 merged 5 commits intoapache:masterfrom Nov 24, 2017
Merged
Conversation
added 5 commits
November 23, 2017 09:49
WillemJiang
reviewed
Nov 23, 2017
| reqQueue.setMaxLifeTimeInQueue(timeInQueue); | ||
| reqQueue.decrementCountInQueue(); | ||
| } | ||
| protected OperationLocator locateOperation(ServicePathManager servicePathManager) { |
Member
There was a problem hiding this comment.
What will happen if we cannot find the OperationLocator?
Contributor
Author
There was a problem hiding this comment.
if locate failed, throw 404 or 405 exception.
WillemJiang
reviewed
Nov 23, 2017
| protected void findRestOperation() { | ||
| super.findRestOperation(); | ||
|
|
||
| boolean cacheRequest = collectCacheRequest(restOperationMeta.getOperationMeta()); |
Contributor
Author
There was a problem hiding this comment.
which one?
cacheRequst? it's setted to requestEx, copy or not copy request body, controlled by this avriable.
Member
There was a problem hiding this comment.
I missed the second line , it makes sense now.
WillemJiang
reviewed
Nov 23, 2017
|
|
||
| public class RestServletProducerInvocation extends RestProducerInvocation { | ||
| @Override | ||
| protected RestOperationMeta findRestOperation() { |
Member
There was a problem hiding this comment.
It looks like the new findRestOperation method is just throw the exception if it cannot find the operation. I'm not sure if this change has some side effect on the user side code.
Contributor
Author
There was a problem hiding this comment.
not change, just move from one class to another class.
WillemJiang
approved these changes
Nov 23, 2017
liubao68
approved these changes
Nov 24, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
use the same mechanism of normal microservice producer
before optimize, edge's decode and filter run in net thread.