[JAV-246]sc code reliable issues, check issue for details#103
Merged
seanyinx merged 2 commits intoapache:masterfrom Jul 29, 2017
liubao68:registry
Merged
[JAV-246]sc code reliable issues, check issue for details#103seanyinx merged 2 commits intoapache:masterfrom liubao68:registry
seanyinx merged 2 commits intoapache:masterfrom
liubao68:registry
Conversation
wujimin
reviewed
Jul 28, 2017
| DynamicIntProperty property = | ||
| DynamicPropertyFactory.getInstance() | ||
| .getIntProperty("cse.service.registry.client.timeout.idle", DEFAULT_TIMEOUT_IN_MS); | ||
| .getIntProperty("cse.service.registry.client.timeout.idle", DEFAULT_TIMEOUT_IN_SECONDS); |
Contributor
There was a problem hiding this comment.
changed from millisecond to second
make sure that nobody used this config.
Contributor
Author
There was a problem hiding this comment.
this config is not documented yet, we will add it to wiki when neccesary(now no need to give this. because 30 seconds is the best and not neccessary to change it .
wujimin
approved these changes
Jul 28, 2017
Contributor
wujimin
left a comment
wujimin
left a comment
There was a problem hiding this comment.
websocket server will send ping pong to client, it's heartbeat.
it seems that the ping pong mechanism can replace our heartbeat logic. create a issue to analysis this?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.