Skip to content

[JAV-280]1. init client and setup to avoid deadlock; 2. avoid NetUtil…#109

Merged
WillemJiang merged 1 commit intoapache:masterfrom
liubao68:client_init
Aug 8, 2017
Merged

[JAV-280]1. init client and setup to avoid deadlock; 2. avoid NetUtil…#109
WillemJiang merged 1 commit intoapache:masterfrom
liubao68:client_init

Conversation

@liubao68
Copy link
Copy Markdown
Contributor

@liubao68 liubao68 commented Aug 7, 2017

…s to block for a long time because of too many reverse host name lookup

…s to block for a long time because of too many reverse host name lookup
@coveralls
Copy link
Copy Markdown

Coverage Status

Coverage decreased (-0.01%) to 85.363% when pulling 1e3b442 on liubao68:client_init into 4aaf86b on ServiceComb:master.

}

private boolean deployClient() {
return HighwayClientManager.INSTANCE.getHighwayClient(true) != null &&
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这部分的内容感觉有点重复啊!

Copy link
Copy Markdown
Contributor Author

@liubao68 liubao68 Aug 8, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

是的。3种不同的transport。 不同的实现里面基本都是一样的过程。 有一定重复度比较正常。 如果放在一起,就变得不那么独立,也不是很好。

@WillemJiang WillemJiang merged commit c52c246 into apache:master Aug 8, 2017
@WillemJiang WillemJiang modified the milestone: 0.2.0 Aug 19, 2017
@liubao68 liubao68 deleted the client_init branch January 5, 2018 07:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants