JAV-283 Unified servlet init#114
Conversation
… not return null, let's user know the error earlier
…serviceRegistry should init earlier
…vlet init, sevlet can not get transport reference
| </param-value> | ||
| </context-param> | ||
|
|
||
| <!-- usage 1 equals usage 2 --> |
There was a problem hiding this comment.
If these two cases are same, we don't need to keep the case 2 here.
There was a problem hiding this comment.
document had not finished now, so remain the information here
after document finished, move the description to the document
| } | ||
|
|
||
| // web container did not did listen now. | ||
| // so mock to listen, and then close. |
There was a problem hiding this comment.
I guess you just want to test if the port is open for use. Spring should do it, Do you have to do it yourself ?
There was a problem hiding this comment.
if dynamic inject servlet, depend on if web container listened
but for embed web container, did not listen in this time, for unified the inject logic, we do listen and close in this time.
There was a problem hiding this comment.
Can we just put the "RestServletInjector.defaultInject(servletContext);" there instead of checking the port?
It's much simple, you don't need to check the port here.
There was a problem hiding this comment.
can not.
if serviceComb work with spring boot embed web container, and serviceComb use another port(that means use vertx rest transport), if this time
if we register our servlet, will cause embed web container failed
3 participants
No description provided.