JAV-221 make vertx eventloop thread name related to vertx name#97
Merged
WillemJiang merged 1 commit intoapache:masterfrom Jul 27, 2017
Merged
JAV-221 make vertx eventloop thread name related to vertx name#97WillemJiang merged 1 commit intoapache:masterfrom
WillemJiang merged 1 commit intoapache:masterfrom
Conversation
previous name is "vert.x-eventloop-thread-{number}"
new name is "{name}-vert.x-eventloop-thread-{number}"
|
Changes Unknown when pulling ee5356d on wujimin:vertx-eventloop-name into ** on ServiceComb:master**. |
liubao68
reviewed
Jul 25, 2017
Contributor
liubao68
left a comment
liubao68
left a comment
There was a problem hiding this comment.
为了实现可维护性需求使用反射，增加了对第三方的依赖和耦合，个人偏好不做这样的优化。
Contributor
Author
|
yes |
Contributor
|
return Vertx.vertx(vertxOptions) is a factory method , after change, we new a object our self, most of time UT can not guarantee this |
Contributor
Author
|
UT do not care for this , thread name only for runtime. |
Contributor
Author
|
just only one test case check the thread name , this case added in this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
previous name is "vert.x-eventloop-thread-{number}"
new name is "{name}-vert.x-eventloop-thread-{number}"