JAV-141 resolve spelling mistake for configuration item problem#98
Merged
WillemJiang merged 1 commit intoapache:masterfrom Jul 25, 2017
Merged
Conversation
read new correct config item first if value is empty, then read old wrong config item.
|
Changes Unknown when pulling 87084ac on wujimin:resolve-wrong-config-item into ** on ServiceComb:master**. |
liubao68
approved these changes
Jul 25, 2017
| "Define propertyExtendedClass %s in yaml, but not implement the interface PropertyExtended.", | ||
| extendedPropertyClass); | ||
| LOGGER.error(errMsg); | ||
| throw new Error(errMsg); |
Contributor
There was a problem hiding this comment.
尽管是配置错误，不让启动，在程序里面throw Error, Exception, RuntimeException，或者捕获这些异常，都不是很友好的代码结构，这会导致使用者代码控制流程很难写。代码应该尽可能使用确切的异常类型来表达具体的错误。
Contributor
Author
There was a problem hiding this comment.
just refused to boot.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
read new correct config item first
if value is empty, then read old wrong config item.