Skip to content

Vsion dataset #383

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 2 commits into
base: jlp/memmap_dataset
Choose a base branch
from
Draft

Vsion dataset #383

wants to merge 2 commits into from

Conversation

@jlamypoirier
Copy link
Collaborator

@jlamypoirier jlamypoirier commented Oct 30, 2025 •
edited
Loading

✨ Description

  • Add patch sample type to handle image patches and similar objects.
  • Add optional image patches to language model samples
    *Update gpt preparator to support images and perform the necessary offline preprocessing.
  • Image normalization can't be done offline because of file size issues. Added it in the language model reader. Works, but not ideal and lacks configurability.
  • TODO Add image separators for patches (lenghts?) so we can calculate cu_seqlens.
  • TODO Add tests for images.

@jlamypoirier jlamypoirier mentioned this pull request Oct 31, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jlamypoirier