-
Notifications
You must be signed in to change notification settings - Fork 907
Resolve incident UI page #1762
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Resolve incident UI page #1762
Conversation
hi @rohi-v Thanks for reviewing. can you please let me know which file you are referring as intended. as a functionality to work we need UI action, script include, you want that be in single file? i aslo added readme file. |
|
@naveensnow yes, Reopened. Validating. |
rohi-v
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please update the readme file to explain the use case and how it works.
added more description of use case and how it works
@rohi-v can you please validate |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please mention as a comment in below code on where below code will be used.
I can see 2 seperate codes for UI Action, keep the necessary one and remove the file which is not requ
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please mention as a comment in below code on where below code will be used.
I can see 2 seperate codes for UI Action, keep the necessary one and remove the file which is not required.
@rohi-v i dont see any two files which one you are referring

There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's updated now. Thank you.
there were 2 codes so specifying which one to use where will help because the method name 'ResolveIncident()' is same in both the scripts.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's updated now. Thank you.
there were 2 codes so specifying which one to use where will help because the method name 'ResolveIncident()' is same in both the scripts.
@rohi-v updated the function name.
rohi-v
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything looks good
When I submit without filling the details, It's still resolving the incident. I would suggest making the fields mandatory in the Popup.
making the values mandatory
adding option None to make the validation
@rohi-v updated |
|
Looks Good, Approved. Thank you for your contribution. |
PR Description:
Pull Request Checklist
Overview
Code Quality
Repository Structure Compliance
Core ServiceNow APIs/Server-Side Components/Client-Side Components/Modern Development/Integration/Specialized Areas/Documentation
Restrictions