Skip to content

Conversation

@HackoDev1530
Copy link
Contributor

PR Description: A onChange client script and a script includes that add the X number of business days

Pull Request Checklist

Overview

  • [X ] I have read and understood the CONTRIBUTING.md guidelines
  • [ X] My pull request has a descriptive title that accurately reflects the changes
  • [X ] I've included only files relevant to the changes described in the PR title and description
  • [ X] I've created a new branch in my forked repository for this contribution

Code Quality

  • [X ] My code is relevant to ServiceNow developers
  • [X ] My code snippets expand meaningfully on official ServiceNow documentation (if applicable)
  • [X ] I've disclosed use of ES2021 features (if applicable)
  • [ X] I've tested my code snippets in a ServiceNow environment (where possible)

Repository Structure Compliance

  • [X ] I've placed my code snippet(s) in one of the required top-level categories:
    • Core ServiceNow APIs/
    • Server-Side Components/
    • Client-Side Components/
    • Modern Development/
    • Integration/
    • Specialized Areas/
  • [X ] I've used appropriate sub-categories within the top-level categories
  • [ X] Each code snippet has its own folder with a descriptive name

Documentation

  • [ X] I've included a README.md file for each code snippet
  • [ X] The README.md includes:
    • Description of the code snippet functionality
    • Usage instructions or examples
    • Any prerequisites or dependencies
    • (Optional) Screenshots or diagrams if helpful

Restrictions

  • My PR does not include XML exports of ServiceNow records
  • [ X] My PR does not contain sensitive information (passwords, API keys, tokens)
  • [X ] My PR does not include changes that fall outside the described scope

@earlduque earlduque self-assigned this Oct 7, 2025
Copy link
Contributor

@earlduque earlduque left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, thank you for your contribution. Everything looks good except for I would prefer if you put them all into one single folder so that people will know that the files are related to each other, or update each README to link to the other README so that people have context of where the other related script is. Once you make either one of those changes, I will be happy to approve it for merging.

@earlduque earlduque removed their assignment Oct 7, 2025
@HackoDev1530
Copy link
Contributor Author

@earlduque Thank you for the review. I've updated the README files in both folders. Please review and let me know if anything needs to be changed.

@earlduque earlduque self-assigned this Oct 8, 2025
Copy link
Contributor

@earlduque earlduque left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not exactly what I was looking for, but I went ahead and edited the files for you. You should go take a look and see how I ended up linking the relative pathway to the other README file so that people could just click on it and be directed straight to the file instead of having to look for it themselves.

@earlduque earlduque merged commit 60c29e8 into ServiceNowDevProgram:main Oct 8, 2025
@earlduque
Copy link
Contributor

Thanks for submitting!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants