-
Notifications
You must be signed in to change notification settings - Fork 910
Feature/auto populate planned end date #1930
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/auto populate planned end date #1930
Conversation
earlduque
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey, thank you for your contribution. Everything looks good except for I would prefer if you put them all into one single folder so that people will know that the files are related to each other, or update each README to link to the other README so that people have context of where the other related script is. Once you make either one of those changes, I will be happy to approve it for merging.
|
@earlduque Thank you for the review. I've updated the README files in both folders. Please review and let me know if anything needs to be changed. |
earlduque
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not exactly what I was looking for, but I went ahead and edited the files for you. You should go take a look and see how I ended up linking the relative pathway to the other README file so that people could just click on it and be directed straight to the file instead of having to look for it themselves.
|
Thanks for submitting! |
PR Description: A onChange client script and a script includes that add the X number of business days
Pull Request Checklist
Overview
Code Quality
Repository Structure Compliance
Core ServiceNow APIs/Server-Side Components/Client-Side Components/Modern Development/Integration/Specialized Areas/Documentation
Restrictions