Skip to content

Conversation

@WillemZeiler
Copy link
Contributor

PR Description:

Remove this Regex, as it is not in the right folder and is a duplicate of a Regex in the regex folder: Specialized Areas/Regular Expressions/Check if number has 10 digits https://github.com/WillemZeiler/code-snippets/tree/f1f5267a806b39e8c63703f8b4274a850c11448f/Specialized%20Areas/Regular%20Expressions/Check%20if%20number%20has%2010%20digits.

Besides the 10 digit Regex check it does not anything related to fax numbers.
Quick google search got me these formats f.e.:
+CountryCode-AreaCode-LocalNumber
00CountryCode-AreaCode-LocalNumber
(CountryCode) AreaCode-LocalNumber
AreaCode-LocalNumber
(LocalNumber only)
1-800-LocalNumber
1-888-LocalNumber

Pull Request Checklist

Overview

  • Put an x inside of the square brackets to check each item.
  • I have read and understood the CONTRIBUTING.md guidelines
  • My pull request has a descriptive title that accurately reflects the changes and the description has been filled in above.
  • I've included only files relevant to the changes described in the PR title and description
  • I've created a new branch in my forked repository for this contribution

Code Quality

  • My code is relevant to ServiceNow developers
  • My code snippets expand meaningfully on official ServiceNow documentation (if applicable)
  • I've disclosed use of ES2021 features (if applicable)
  • I've tested my code snippets in a ServiceNow environment (where possible)

Repository Structure Compliance

  • I've placed my code snippet(s) in one of the required top-level categories:
    • Core ServiceNow APIs/
    • Server-Side Components/
    • Client-Side Components/
    • Modern Development/
    • Integration/
    • Specialized Areas/
  • I've used appropriate sub-categories within the top-level categories
  • Each code snippet has its own folder with a descriptive name

Documentation

  • I've included a README.md file for each code snippet
  • The README.md includes:
    • Description of the code snippet functionality
    • Usage instructions or examples
    • Any prerequisites or dependencies
    • (Optional) Screenshots or diagrams if helpful

Restrictions

  • My PR does not include XML exports of ServiceNow records
  • My PR does not contain sensitive information (passwords, API keys, tokens)
  • My PR does not include changes that fall outside the described scope

… Number directory

Remove this Regex, as it is not in the right folder and is a duplicate of a Regex in the regex folder Specialized Areas/Regular Expressions/Check if number has 10 digits. I noticed this when I was refactoring that one.
@ivan-betev
Copy link
Contributor

Great job! 🗡️

@ivan-betev ivan-betev merged commit 2e7d910 into ServiceNowDevProgram:main Oct 12, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants