Skip to content

Created new instance scan check for client script usage of GlideRecord API #38

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 2, 2022
Merged

Created new instance scan check for client script usage of GlideRecord API #38

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a70f769
Created new instance scan to check to make sure that Client script do…
Sep 30, 2022
fc538e5
Updated Readme for new instance scan check
snamjosh Oct 2, 2022
4e9d1a9
Merge branch 'master' into master
earlduque Oct 2, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -154,6 +154,9 @@ For table that store reports definition there is also posibility to assign roles
### Scheduled Job with RunAs set as Locked Out user
Detecting no longer active user with flag Locked Out set to true that is set as a RunAs for Scheduled Job

### Client Scripts should not use GlideRecord() API
Verify that instance doesn't have GlideRecord() usage in client scripts and instead make use of GlideAjax.

## Category: User Experience


Expand Down
2 changes: 1 addition & 1 deletion ca8467c41b9abc10ce0f62c3b24bcbaa/checksum.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
d9mOi167Wrul7up4wwyqrhWcfoFzmpRPl8XHUy2NakkDwIp9v8SSIF2D3NpLQ2DMjyxbDN9JtMW2Yb-iTlq9XxiTE-Vi_vPEND9BwNrqu5544ZVluYDGz08zbS3Mi9TPNbhLGnCHACi6gQbPM269fU9Exwsqq7xEg1CXMCQQJ8D0NuWGjv8Q4QWG9JLmZKVLhGxKqZfW7i4EDlFuvswZdd175QcFotLplLXl2Bi7dWSpD_N7J8pY32Aoy8p5hce49vhyfikPxaGE1eqFvrDM_G-E5mBJwh0_KGRut_m-l_fTXy-II9o5Nc9K-B_ys72jWTQpPx3wOFFWq1fFFzHmqN8AxqImMJRVe39pVZw1sctf5DlcRqCxWka8PlLpTFvro005AZE91Cp9T6OMKZFNCebxZN6dpx9-gzFIp-BiVUCyO1vb5W5lTmq_BLejo-NRsu9jsivngB7_-vaNd0c_pTILnHpfkheG-bX1YHkftIgxHnT_6cisDt-aWcS6pkQb0rJkQAkk51vyTykJSsLgniBrppo807NEBArJSrFoPfy2ikmUcOvUK9IN9I_YZGNRYQMdhdVGFnoG38t8nDlszXmyiqCPL0rKQxkgTHABYq2Ywltgaf3HammrbO8NSVrtJvuN2Bzy-wsKi6gvFV8pI6lYJ5YR4FlByiE5Bsvupxk
wfk5cLJIFILf--CScx11T_HxKnvFi_tvVGWQ4MVoUD4xRjeg23hbQQ-YthZaO5rdQRi5RO0Ek_vy1jQxfj8my5NnSqX76ss9Totvk18Z5SgfR8FHjV9QH256pks9HGGF8Fbyn3AtYoCn4KUpxUI-hW2X1yAAwp0PKYgo9q_DlLzvRd1yem1bLqaCLTW-CW_IDtQoDlk5wdVR2XKYqeAsNOKgOI_7m84DsgiIZwn78t5DcQ-jEtyZKCIFsznrSce2sFSW0EZOwYVQsFwvXIhSpsyNaLesyP7N8PVuw3rBsw5nojwgPkNbJW_sYegEICD8CTNIm-OdS5tsS0nifJQNN5erG3FlGykruc1JjG1YWoQs2Nxq4FCevGLSjX-C9g9AZUtnMmyGt2wZTPTdPYwzKmoYQ1642r7CJdJ8fvjHWViLp2__NT9Wo4rJBHqYxd7rADLu-on_5a1FTXlTKLuck-Ges27pJcmyYz1RqJJHwJQ2bPeZZ6AgYIdqvLKhx87K_kDj76p9QIw36GDaNuUCAhOuB3JU5UCBdWtS_G-6GebWyasL0pMVt5DXczRH2BUeJTttW7stKIfY3p4_7pDVvd2gcE8LI6TRLGA-k-KX6c-6MeIAp8LFoOMwGH07Dc-fgPQDfhrvOnyF1jMAq2scd1kDC005jUwjKCNiM-JqiyE
39 changes: 39 additions & 0 deletions ...67c41b9abc10ce0f62c3b24bcbaa/update/scan_table_check_ba0c998d875251106b0f20af8bbb3515.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,39 @@
<?xml version="1.0" encoding="UTF-8"?><record_update table="scan_table_check">
<scan_table_check action="INSERT_OR_UPDATE">
<active>true</active>
<advanced>false</advanced>
<category>performance</category>
<conditions table="sys_script_client">scriptLIKEGlideRecord^EQ<item endquery="false" field="script" goto="false" newquery="false" operator="LIKE" or="false" value="GlideRecord"/>
<item endquery="true" field="" goto="false" newquery="false" operator="=" or="false" value=""/>
</conditions>
<description>Client script should be using GlideAjax if you need to make asyc calls to Server to get data from Server. GlideRecord() API shouldn't be used to avoid performance issues.</description>
<documentation_url/>
<finding_type>scan_finding</finding_type>
<name>GlideRecord API in client script</name>
<priority>2</priority>
<resolution_details>Client scripts run on browser and they uses either data available on the form or data retrieved from the database.&#13;
Use client data as much as possible to eliminate the need for time-consuming server lookups i.e. GlideRecord.&#13;
The best ways to get data into form/browser from the database are g_scratchpad, and asynchronous GlideAjax lookup</resolution_details>
<run_condition/>
<score_max>100</score_max>
<score_min>0</score_min>
<score_scale>1</score_scale>
<script><![CDATA[(function (engine) {

// Add your code here

})(engine);]]></script>
<short_description>Client script with GlideRecord API calls</short_description>
<sys_class_name>scan_table_check</sys_class_name>
<sys_created_by>admin</sys_created_by>
<sys_created_on>2022-09-30 21:33:04</sys_created_on>
<sys_id>ba0c998d875251106b0f20af8bbb3515</sys_id>
<sys_name>GlideRecord API in client script</sys_name>
<sys_package display_value="Example Instance Checks" source="x_appe_exa_checks">ca8467c41b9abc10ce0f62c3b24bcbaa</sys_package>
<sys_policy/>
<sys_scope display_value="Example Instance Checks">ca8467c41b9abc10ce0f62c3b24bcbaa</sys_scope>
<sys_update_name>scan_table_check_ba0c998d875251106b0f20af8bbb3515</sys_update_name>
<table>sys_script_client</table>
<use_manifest>false</use_manifest>
</scan_table_check>
</record_update>