Skip to content

Conversation

@Iuliak
Copy link
Contributor

@Iuliak Iuliak commented Oct 12, 2023

A sign that the close_states are not set correctly on the incident table. This check can be done on any table, especially there where the State model was changed from OOTB or for custom extended tables. The problem with this kind of records is that they can influence the reports on active records on the respective table.
It is a simple table instance check.

…ign that the close_states are not set correctly on the incident table). This check can be done on any table, especially there where the State model was changed from OOTB or for custom extended tables. The problem with this kind of records is that they can influence the reports on active records on the respective table.
@Iuliak Iuliak changed the title Check the incidents that are closed or canceled but still active (a s… Check the incidents that are closed or canceled but still active Oct 12, 2023
@niamccash
Copy link
Contributor

@Iuliak Can you please add a description of the check to the readme file as part of this PR?

@niamccash niamccash self-assigned this Oct 12, 2023
@Iuliak
Copy link
Contributor Author

Iuliak commented Oct 13, 2023

Readme.md
Hi @niamccash,
is it ok like this?
Thank you!

@SapphicFire
Copy link
Contributor

That content is good. It just needs to be added to the repository readme.md file under the appropriate category as another commit, with a heading as per the other entries 😃

…ctive check README.md

Added the Check the incidents that are closed or canceled but still active check
@Iuliak
Copy link
Contributor Author

Iuliak commented Oct 13, 2023

Ah ok, done :) hopefully :D

@niamccash
Copy link
Contributor

@Iuliak Great description of the check. Good job! Could you please move the description in the readme to the appropriate category section? The readme file has different sections for different categories of Instance Scan.

I see the scan you created is under the Manageability category but the description in the readme was put under the User Experience category.

Moved the Check for incidents closed and still active in the manageability Section
@Iuliak
Copy link
Contributor Author

Iuliak commented Oct 13, 2023

@niamccash yes, sorry .. I think its ok now.

@niamccash niamccash merged commit 4a9b06c into ServiceNowDevProgram:master Oct 13, 2023
@niamccash
Copy link
Contributor

@Iuliak no apologies needed. It happens. Thank you for updating. Looks great! PR accepted!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants