Allow OrmLiteConfig.StringFilter to fire on null strings

[robertmiles3]

In case one wanted to have OrmLiteConfig.StringFilter deal with a null string coming back from the DB (like setting it to string.Empty instead), it would be nice to allow the StringFilter to be called on the null string. However, currently it doesn't because the as conversion returns null and therefore skips it. A downside is that I could see this being a breaking change for users who are currently not handling null possibilities within their StringFilter implementations.

Seems like a design-related question whether it should be allowed, so thought I'd ask. If it stays as-is, can you think of another option to have a StringFilter-esque operation on null strings?

[mythz]

Wont be called in StringFilter but I've just added a new generic OrmLiteConfig.OnDbNullFilter that can be used for any null value instead in this commit: ServiceStack/ServiceStack.OrmLite@e857320

Where you can return "NULL" for null strings with:

OrmLiteConfig.OnDbNullFilter = fieldDef => 
    fieldDef.FieldType == typeof(string)
        ? "NULL"
        : null;

This change is available from v4.0.41+ that's now available on MyGet.

In future please reserve this Issues site for reproducible bugs/issues, (i.e. runnable code with failing tests). You can use https://forums.servicestack.net/ for general advice, design or feature discussion, etc or UserVoice for feature requests.

[robertmiles3]

Thanks Demis. Sounds good. Sorry for the wrong spot. Hope all is well!

On Mon, Jun 29, 2015 at 7:18 PM, Demis Bellot notifications@github.com
wrote:

Wont be called in StringFilter but I've just added a new generic OrmLiteConfig.OnDbNullFilter that can be used for any null value instead in this commit: ServiceStack/ServiceStack.OrmLite@e857320
Where you can return "NULL" for null strings with:

OrmLiteConfig.OnDbNullFilter = fieldDef => 
    fieldDef.FieldType == typeof(string)
        ? "NULL"
        : null;

This change is available from v4.0.41+ that's now available on MyGet.

In future please reserve this Issues site for reproducible bugs/issues, (i.e. runnable code with failing tests). You can use https://forums.servicestack.net/ for general advice, design or feature discussion, etc or UserVoice for feature requests.

Reply to this email directly or view it on GitHub:
#306 (comment)