This repository was archived by the owner on Jan 18, 2023. It is now read-only.
Brian/core issuance order fixes #154
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bweick
changed the title
Pull Request Test Coverage Report for Build 1178
💛 - Coveralls |
…. First pass at re-writing tests.
…or fees no relayer transfers executed. Created internal function to construct IssuanceOrder. Tests backing everything up.
asoong
approved these changes
Aug 9, 2018
| // Send left over maker token balance to taker | ||
| ITransferProxy(state.transferProxy).transfer( | ||
| _order.makerToken, | ||
| _requiredMakerTokenAmount.sub(_makerTokenUsed), // Required less used is amount sent to taker |
There was a problem hiding this comment.
I don't understand this comment
bweick
force-pushed
the
brian/core_issuance_order_fixes
branch
from
980c8af to
d9874b1
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.