Move vault and transferProxy settings into the Core constructor by felix2feng · Pull Request #172 · SetProtocol/set-protocol-contracts · GitHub

This repository was archived by the owner on Jan 18, 2023. It is now read-only.

Contributor

felix2feng commented Aug 15, 2018

First step is to move transfer proxy and vault setup to constructor.

Add constructor on Core
Update unit tests accordingly


          First step is to move transfer proxy and vault setup to constructor

7c10443

felix2feng requested a review from asoong

August 15, 2018 18:47


          Also update migrations

d97f7b7

coveralls commented Aug 15, 2018

Pull Request Test Coverage Report for Build 1321

2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 100.0%

Totals
Change from base Build 1315:	0.0%
Covered Lines:	341
Relevant Lines:	341

💛 - Coveralls

felix2feng merged commit 3902fa9 into master

felix2feng deleted the felix/contract-permissions branch

August 16, 2018 04:50

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet