This repository was archived by the owner on Jan 18, 2023. It is now read-only.
Brian/rebalance manager update #363
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
felix2feng
approved these changes
Jan 29, 2019
| * @param _setTokenFactory The address of the SetTokenFactory | ||
| * @param _auctionLibrary The address of auction price curve to use in rebalance | ||
| * @param _auctionTimeToPivot The amount of time until pivot reached in rebalance | ||
| * @param _btcMultiplier With _ethMultiplier, the ratio amount of wbtc to include |
Contributor
There was a problem hiding this comment.
Maybe we can add a comment above about why / how this multiplier can be used.
| btcMultiplier, | ||
| ethMultiplier | ||
| ); | ||
| console.log(expectedNextSetParams['units']); |
| ethMultiplier | ||
| ); | ||
| console.log(expectedNextSetParams['units']); | ||
| expect(JSON.stringify(nextSetUnits)).to.be.eql(JSON.stringify(expectedNextSetParams['units'])); |
Pull Request Test Coverage Report for Build 3939
💛 - Coveralls |
…n be used to make custom allocations.
bweick
force-pushed
the
brian/rebalance_manager_update
branch
from
97f1a0a to
969388f
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.