This repository was archived by the owner on Jan 18, 2023. It is now read-only.
Brian/require issue to start rebalance #376
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hares equals 0 drawdown.
Pull Request Test Coverage Report for Build 4134
💛 - Coveralls |
felix2feng
reviewed
Feb 4, 2019
| ( | ||
| , | ||
| uint256 calculatedUnitShares | ||
| ) = StandardSettleRebalanceLibrary.calculateNextSetIssueQuantity( |
Contributor
There was a problem hiding this comment.
Can we write another function in StandardSettleRebalanceLibrary called something like canPeformSuccessfulSettlement or so instead of passing through calculatedUnitShares?
| _vaultAddress | ||
| ); | ||
|
|
||
| require( |
Contributor
There was a problem hiding this comment.
canPeformSuccessfulSettlement function result would be more clear
| // Require remainingCurrentSets to be greater than minimumBid otherwise no bidding would | ||
| // be allowed | ||
| require( | ||
| biddingParameters.remainingCurrentSets >= biddingParameters.minimumBid, |
Contributor
There was a problem hiding this comment.
Can we also have a function in settleLibrary to reflect this equality? It's also in endFailedAuction
felix2feng
approved these changes
Feb 6, 2019
kermankohli
pushed a commit
that referenced
this pull request
Feb 20, 2019
* Added UpdatableConstantAuctionPriceCurve. * SettleRebalance check that unitShares isn't 0. EndFailedAuction unitShares equals 0 drawdown. * Removed unnecessary require statement. * Fixed tests. * Fix rebalanceAuctionModule tests. * Add DEFAULT_GAS to fix tests. * Add DEFAULT_GAS to fix tests. * Updated some commments. * Change control logic to meet coverage requirements. * Consolidate unitShares checking logic. * Fix extraneous space * Undo commit
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.